Merge lp://staging/~alecu/ubuntu-sso-client/keyring-api-change into lp://staging/ubuntu-sso-client

Proposed by Alejandro J. Cura
Status: Merged
Approved by: Rodrigo Moya
Approved revision: 593
Merged at revision: 599
Proposed branch: lp://staging/~alecu/ubuntu-sso-client/keyring-api-change
Merge into: lp://staging/ubuntu-sso-client
Diff against target: 526 lines (+219/-152)
4 files modified
ubuntu_sso/keyring.py (+89/-38)
ubuntu_sso/main.py (+1/-28)
ubuntu_sso/tests/test_keyring.py (+125/-29)
ubuntu_sso/tests/test_main.py (+4/-57)
To merge this branch: bzr merge lp://staging/~alecu/ubuntu-sso-client/keyring-api-change
Reviewer Review Type Date Requested Status
Rodrigo Moya (community) Approve
John Lenton (community) Approve
Review via email: mp+33840@code.staging.launchpad.net

Commit message

Use the keyring unlocking gnomekeyring APIs (LP: #623622)
Search all keyrings for the credentials (LP: #624033)

Description of the change

Use the keyring unlocking gnomekeyring apis and search all keyrings for the credentials

To post a comment you must log in.
Revision history for this message
John Lenton (chipaca) wrote :

tests are delicious!

review: Approve
Revision history for this message
Rodrigo Moya (rodrigo-moya) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches