Ubuntu Touch session manager

Merge lp://staging/~albaguirre/ubuntu-touch-session/enable-overlays into lp://staging/ubuntu-touch-session

  1. enable-overlays
  2. Merge into trunk
Proposed by Alberto Aguirre
Status: Merged
Approved by: Ricardo Salveti
Approved revision: 212
Merged at revision: 214
Proposed branch: lp://staging/~albaguirre/ubuntu-touch-session/enable-overlays
Merge into: lp://staging/ubuntu-touch-session
Diff against target: 9 lines (+1/-1)
1 file modified
usc-wrapper (+1/-1)
To merge this branch: bzr merge lp://staging/~albaguirre/ubuntu-touch-session/enable-overlays
Reviewer Review Type Date Requested Status
Ricardo Salveti (community) Approve
Ricardo Mendoza (community) Approve
Review via email: mp+229112@code.staging.launchpad.net

Commit message

Enable use of h/w overlays by unity-system-compositor if available

Description of the change

Enable use of h/w overlays by unity-system-compositor if available

Enabling overlays allows the mir android platform to bypass composition when possible which will have an impact on performance and/or power consumption.

To post a comment you must log in.
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

The only side effect I got, when testing on manta, is that the spinner stops for a few seconds before unity8 is fully up when enabling this option. Is this expected?

On krillin it's easily making the device to crash in a loop, so we need to better understand why in there (tried again with a clean build and it worked, but failed for jani).

review: Needs Information
Revision history for this message
Jani Monoses (jani) wrote :

I made this change on image 163 and it resulted in a boot loop.
Changing it from recovery mode to be --disable-overlays=true fixed the boot again.

Revision history for this message
Alberto Aguirre (albaguirre) wrote :

"...when testing on manta, is that the spinner stops for a few seconds before unity8 is fully up when enabling this option. Is this expected?..."

No, I'll investigate that.

Revision history for this message
Ricardo Mendoza (ricmm) wrote :

Did your testing include 530? It works fine for me on krillin with that, which should've landed the same day you guys have been testing.

Revision history for this message
Ricardo Mendoza (ricmm) :
review: Approve
Revision history for this message
Alberto Aguirre (albaguirre) wrote :

The spinner halt/stopping has been fixed in mir:

https://code.launchpad.net/~kdub/mir/fix-1352883

Once that lands we should silo and test this again.

Revision history for this message
Ricardo Salveti (rsalveti) wrote :

This will land as mir 0.6.1, so once that is in we should be good to give this another try.

Revision history for this message
Ricardo Salveti (rsalveti) wrote :

Looks good, tested with latest and worked as expected.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches