Mir

Merge lp://staging/~albaguirre/mir/workaround-for-1482274 into lp://staging/mir

Proposed by Alberto Aguirre
Status: Merged
Approved by: Alberto Aguirre
Approved revision: no longer in the source branch.
Merged at revision: 2820
Proposed branch: lp://staging/~albaguirre/mir/workaround-for-1482274
Merge into: lp://staging/mir
Diff against target: 12 lines (+1/-1)
1 file modified
tests/unit-tests/test_glib_main_loop.cpp (+1/-1)
To merge this branch: bzr merge lp://staging/~albaguirre/mir/workaround-for-1482274
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Kevin DuBois (community) Approve
Alan Griffiths Approve
Review via email: mp+267216@code.staging.launchpad.net

Commit message

Workaround for GLibMainLoopTest.propagates_exception_from_server_action failure

The test fails with GCC5 when using -O2 options in armhf which seems to be caused by using identical lambda definitions.
As a workaround the exception message is changed to force the compiler to generate a unique implementation instead of sharing one;this allows the exception to be caught as expected.

Description of the change

Workaround for GLibMainLoopTest.propagates_exception_from_server_action failure

The test fails with GCC5 when using -O2 options in armhf which seems to be caused by using identical lambda definitions.
As a workaround the exception message is changed to force the compiler to generate a unique implementation instead of sharing one;this allows the exception to be caught as expected.

To post a comment you must log in.
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

WTF?!

review: Approve
Revision history for this message
Kevin DuBois (kdub) wrote :

a zany bug, lgtm.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches