Merge lp://staging/~alanbell/onboard/themes into lp://staging/~onboard/onboard/main

Proposed by Alan Bell
Status: Merged
Merged at revision: 519
Proposed branch: lp://staging/~alanbell/onboard/themes
Merge into: lp://staging/~onboard/onboard/main
Diff against target: 200 lines (+181/-0)
4 files modified
themes/ModelM.colors (+46/-0)
themes/ModelM.theme (+14/-0)
themes/Typist.colors (+107/-0)
themes/Typist.theme (+14/-0)
To merge this branch: bzr merge lp://staging/~alanbell/onboard/themes
Reviewer Review Type Date Requested Status
marmuta Needs Information
Review via email: mp+81772@code.staging.launchpad.net

Description of the change

adding two themes, one based on the classic IBM Model M keyboard, and a colourful one showing position of the home keys for touch typing

To post a comment you must log in.
Revision history for this message
marmuta (marmuta) wrote :

Hi Alan, thanks for the color schemes, I finally came around checking them out.

I liked Model-M right away, neat. Although I think it is really asking for a new key style. So I've experimented a bit and came up with something dish-like. It still needs some tweaking, but I think the general idea comes across. I can't seem to attach any screen-shots here unfortunately. Will commit soon.

Some issues with the colors: the latched state of the modifier keys is hardly visible and though they look right, the dark keys are a bit low contrast and hard to read

I'm not so sure about the second color scheme. How would an on-screen keyboard benefit from markings for touch typing? Can you explain? Also, to me the colors make it harder to type on.

review: Needs Information
Revision history for this message
Alan Bell (alanbell) wrote :

Agree about the key style for the model M, might also be more accurate to have the key labels in the top left corner of the keycaps, but then you are trading off accuracy to the physical keyboard against being a good on screen keyboard.
The colourful touch type one is somewhat for educational purposes, and could make more sense on a tablet sized touchscreen device.

Revision history for this message
marmuta (marmuta) wrote :

Yes, I agree about the label trade-off. The smaller the labels, the larger the keyboard has to be on screen to stay readable. I think less obstruction wins over accuracy there. Also, even if the window is large, it might be because someone needs those labels to be really large too.

> The colourful touch type one is somewhat for educational purposes, and could make more sense on a tablet sized touchscreen device.
I see, makes some sense on a tablet then. That reminds me of neglected bug #626064, need to google that.

So, I have merged them both, but did some clean-up and tweaked the colors a bit, hope you don't mind. Model M is a little brighter for better contrast and Typist's right pinky color has less saturation. The dish key is in too, but will need a little more work.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: