Compiz

Merge lp://staging/~alanbell/compiz/fix930783 into lp://staging/compiz/0.9.8

  1. fix930783
  2. Merge into 0.9.8
Proposed by Alan Bell
Status: Merged
Merged at revision: 3260
Proposed branch: lp://staging/~alanbell/compiz/fix930783
Merge into: lp://staging/compiz/0.9.8
Diff against target: 12 lines (+1/-1)
1 file modified
plugins/mousepoll/mousepoll.xml.in (+1/-1)
To merge this branch: bzr merge lp://staging/~alanbell/compiz/fix930783
Reviewer Review Type Date Requested Status
Daniel van Vugt Approve
Review via email: mp+110791@code.staging.launchpad.net

Description of the change

makes compiz enhanced zoom and show mouse plugins considerably smoother to use

To post a comment you must log in.
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Interesting. Though I believe there are bugs related to mousepoll where it keeps polling when it shouldn't. So this fix would make those much worse. For example: bug 961202

Revision history for this message
Alan Bell (alanbell) wrote :

good reason to fix those other bugs then! I haven't noticed any performance problems myself, CPU use doesn't change. I can try some powertop stuff to see what happens when it is idle/locked with 1ms polling time.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

By the way, polling more than once per video frame is pointless. On a 60Hz monitor, that means anything more often than (less than) 16ms. Please try raising the interval up to 10ms so it will be smooth on monitors up to 100Hz. That will still ensure mousepoll gets at least one update per frame on almost all monitors.

And please also let us know which bug(s) in launchpad this fixes. It's not bug 30783 :)

review: Needs Information
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Probably the perceived unsmoothness is because the period of the polling doesn't line up with the period of the redraw. I'm not sure about the best way to fix that, as its the polling for a changed position that causes the redraw. We'll need to have a think about it.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Please modify the default value to 10ms. And please resubmit from a difference branch name since it's not bug 30783.

If you can find any existing bugs this branch fixes then please link them to the branch.

review: Needs Fixing
Revision history for this message
Alan Bell (alanbell) wrote :

typo, it was bug 930783 I will make those changes.

lp://staging/~alanbell/compiz/fix930783 updated
3251. By Alan Bell

10ms is also smooth, should be one poll per frame on almost all output devices still

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Thanks. Next time please click "Resubmit proposal" so it doesn't stay in the old state of "Needs fixing" (and could be potentially overlooked).

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches