unity-mir

Merge lp://staging/~alan-griffiths/unity-mir/use-supported-api into lp://staging/unity-mir

  1. use-supported-api
  2. Merge into trunk
Proposed by Alan Griffiths
Status: Approved
Approved by: Gerry Boland
Approved revision: 246
Proposed branch: lp://staging/~alan-griffiths/unity-mir/use-supported-api
Merge into: lp://staging/unity-mir
Diff against target: 12 lines (+1/-1)
1 file modified
src/unity-mir/shellserverconfiguration.cpp (+1/-1)
To merge this branch: bzr merge lp://staging/~alan-griffiths/unity-mir/use-supported-api
Reviewer Review Type Date Requested Status
Gerry Boland (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+227315@code.staging.launchpad.net

Commit message

The Mir API "the_ipc_factory()" is deprecated in favor of "new_ipc_factory()" - so use the latter as the former is will be removed.

Description of the change

The Mir API "the_ipc_factory()" is deprecated in favor of "new_ipc_factory()" - so use the latter as the former is will be removed.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:246
http://jenkins.qa.ubuntu.com/job/unity-mir-ci/400/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-utopic-amd64-ci/64
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-utopic-armhf-ci/64
        deb: http://jenkins.qa.ubuntu.com/job/unity-mir-utopic-armhf-ci/64/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-utopic-i386-ci/64

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-mir-ci/400/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

 * Are there any related MPs required for this MP to build/function as expected? Please list.

n/a

 * Did you perform an exploratory manual test run of your code change and any related functionality?

No, not sure how to exercise this manually. (But the change just replicates a tested change in Mir.)

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

n/a

Reply
Revision history for this message
Gerry Boland (gerboland) wrote :

LGTM

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Y
 * Did CI run pass? If not, please explain why.
Y

review: Approve
Reply

Unmerged revisions

246. By Alan Griffiths

Don't use deprecated Mir the_ipc_factory() API

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches