MirAL

Merge lp://staging/~alan-griffiths/miral/1.3 into lp://staging/miral/release

1.3
Merge into release

Proposed by Alan Griffiths on 2017-03-24

Status:	Merged
Approved by:	Alan Griffiths on 2017-03-30
Approved revision:	no longer in the source branch.
Merged at revision:	359
Proposed branch:	lp://staging/~alan-griffiths/miral/1.3
Merge into:	lp://staging/miral/release
Diff against target:	453 lines (+124/-28) 17 files modified CMakeLists.txt (+1/-1) debian/changelog (+19/-0) include/miral/set_window_management_policy.h (+3/-3) miral-kiosk/kiosk_main.cpp (+1/-1) miral-shell/decoration_provider.cpp (+12/-1) miral-shell/miral-app.sh (+2/-4) miral-shell/miral-desktop.sh (+1/-1) miral-shell/miral-run.sh (+1/-1) miral-shell/miral-xrun.sh (+21/-1) miral-shell/titlebar_window_manager.cpp (+4/-0) miral/CMakeLists.txt (+1/-1) miral/basic_window_manager.cpp (+10/-0) miral/basic_window_manager.h (+9/-1) miral/set_window_management_policy.cpp (+5/-5) test/test_server.cpp (+1/-1) test/test_window_manager_tools.h (+7/-0) test/workspaces.cpp (+26/-7)
To merge this branch:	bzr merge lp://staging/~alan-griffiths/miral/1.3
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Alan Griffiths			Approve on 2017-03-30
Review via email: mp+320973@code.staging.launchpad.net

Commit message

1.3.1 release

Revision history for this message

Alan Griffiths (alan-griffiths) wrote on 2017-03-30:

Seen this twice in bileto:

[ RUN ] Workspaces.with_two_applications_when_a_window_in_a_workspace_hides_focus_remains_in_workspace
[2017-03-30 07:31:06.592649] mirserver: Starting
[2017-03-30 07:31:06.592873] mirserver: Selected driver: mir:stub-graphics (version 0.26.2)
[2017-03-30 07:31:06.593742] mirserver: Using software cursor
[2017-03-30 07:31:06.624258] mirserver: Selected input driver: mir:stub-input (version: 0.26.2)
[2017-03-30 07:31:06.634376] mirserver: Mir version 0.26.2
[2017-03-30 07:31:06.638238] mirserver: Initial display configuration:
[2017-03-30 07:31:06.651197] mirserver: Output 1: VGA connected, used
[2017-03-30 07:31:06.651288] mirserver: Physical size 0.0" 0x0mm
[2017-03-30 07:31:06.651306] mirserver: Power is on
[2017-03-30 07:31:06.651328] mirserver: Current mode 1600x1600 60.00Hz
[2017-03-30 07:31:06.651346] mirserver: Preferred mode 1600x1600 60.00Hz
[2017-03-30 07:31:06.651362] mirserver: Orientation normal
[2017-03-30 07:31:06.651379] mirserver: Logical size 1600x1600
[2017-03-30 07:31:06.651394] mirserver: Logical position +0+0
/<<BUILDDIR>>/miral-1.3.2+16.04.20170330/test/workspaces.cpp:534: Failure
Value of: tools.active_window()
Expected: is equal to 1
Actual: 1 (of type miral::Window)
tools.active_window(): a window
server_window(dialog): dialog

GMOCK WARNING:
Uninteresting mock function call - returning directly.
Function call: advise_focus_gained(@0x7f80003200 8-byte object <80-4A 00-80 7F-00 00-00>)
Stack trace:

GMOCK WARNING:
Uninteresting mock function call - returning directly.
Function call: advise_removing_from_workspace(@0x7f8000ac30 16-byte object <50-6A 9F-0D 00-00 00-00 40-6A 9F-0D 00-00 00-00>, @0x7f977fd800 { 1 })
Stack trace:

GMOCK WARNING:
Uninteresting mock function call - returning directly.
Function call: advise_focus_gained(@0x7f80007940 8-byte object <50-8A 00-80 7F-00 00-00>)
Stack trace:
[2017-03-30 07:31:06.925379] mirserver: Stopping
[ FAILED ] Workspaces.with_two_applications_when_a_window_in_a_workspace_hides_focus_remains_in_workspace (344 ms)

Seen this twice in bileto:

[ RUN      ] Workspaces.with_two_applications_when_a_window_in_a_workspace_hides_focus_remains_in_workspace
[2017-03-30 07:31:06.592649] mirserver: Starting
[2017-03-30 07:31:06.592873] mirserver: Selected driver: mir:stub-graphics (version 0.26.2)
[2017-03-30 07:31:06.593742] mirserver: Using software cursor
[2017-03-30 07:31:06.624258] mirserver: Selected input driver: mir:stub-input (version: 0.26.2)
[2017-03-30 07:31:06.634376] mirserver: Mir version 0.26.2
[2017-03-30 07:31:06.638238] mirserver: Initial display configuration:
[2017-03-30 07:31:06.651197] mirserver:   Output 1: VGA connected, used
[2017-03-30 07:31:06.651288] mirserver:       Physical size 0.0" 0x0mm
[2017-03-30 07:31:06.651306] mirserver:       Power is on
[2017-03-30 07:31:06.651328] mirserver:       Current mode 1600x1600 60.00Hz
[2017-03-30 07:31:06.651346] mirserver:       Preferred mode 1600x1600 60.00Hz
[2017-03-30 07:31:06.651362] mirserver:       Orientation normal
[2017-03-30 07:31:06.651379] mirserver:       Logical size 1600x1600
[2017-03-30 07:31:06.651394] mirserver:       Logical position +0+0
/<<BUILDDIR>>/miral-1.3.2+16.04.20170330/test/workspaces.cpp:534: Failure
Value of: tools.active_window()
Expected: is equal to 1
  Actual: 1 (of type miral::Window)
tools.active_window(): a window
server_window(dialog): dialog

GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: advise_focus_gained(@0x7f80003200 8-byte object <80-4A 00-80 7F-00 00-00>)
Stack trace:

GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: advise_removing_from_workspace(@0x7f8000ac30 16-byte object <50-6A 9F-0D 00-00 00-00 40-6A 9F-0D 00-00 00-00>, @0x7f977fd800 { 1 })
Stack trace:

GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: advise_focus_gained(@0x7f80007940 8-byte object <50-8A 00-80 7F-00 00-00>)
Stack trace:
[2017-03-30 07:31:06.925379] mirserver: Stopping
[  FAILED  ] Workspaces.with_two_applications_when_a_window_in_a_workspace_hides_focus_remains_in_workspace (344 ms)

review: Needs Fixing

Revision history for this message

Alan Griffiths (alan-griffiths) on 2017-03-30:

review: Approve

lp://staging/~alan-griffiths/miral/1.3 updated on 2017-03-30

359. By CI Train Bot Account on 2017-03-30: * New upstream release 1.3.2 (https://launchpad.net/miral/+milestone/1.3.2)
  - ABI summary:
    . miral ABI unchanged at 2
  - Enhancements:
    . [miral-shell] Add a keyboard shortcut for forcing fullscreen
  - Bugs fixed:
    . [miral-examples] With latest zesty's libstdc++-6-dev miral-shell will
      crash when trying to draw its background text. (LP: #1677550)
    . [miral-examples] Update miral-xrun to match GDK changes (LP: #1675115)
    . [miral-examples] change the server and client launch scripts to avoid
      using the default Mir socket (LP: #1675794)
    . [libmiral] Fix FTBFS against Mir < 0.26 (Xenial, Yakkety)
    . [libmiral] correct spelling of miral/set_window_management_policy.h
    . Update to fix FTBFS against lp:mir (and clang)