Merge lp://staging/~alan-griffiths/mir/fix-1667645 into lp://staging/mir
Proposed by
Alan Griffiths
Status: | Merged |
---|---|
Approved by: | Daniel van Vugt |
Approved revision: | no longer in the source branch. |
Merged at revision: | 4055 |
Proposed branch: | lp://staging/~alan-griffiths/mir/fix-1667645 |
Merge into: | lp://staging/mir |
Prerequisite: | lp://staging/~alan-griffiths/mir/create-windowspec-for-all-types |
Diff against target: |
33 lines (+3/-2) 2 files modified
src/server/scene/application_session.cpp (+3/-0) tests/acceptance-tests/test_client_surfaces.cpp (+0/-2) |
To merge this branch: | bzr merge lp://staging/~alan-griffiths/mir/fix-1667645 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mir CI Bot | continuous-integration | Approve | |
Brandon Schaefer (community) | Approve | ||
Alexandros Frantzis (community) | Approve | ||
Review via email: mp+318216@code.staging.launchpad.net |
Commit message
Don't dereference the end iterator in ms::Application
Description of the change
The UB manifests a visible problem reliably by:
$ bin/mir_
To post a comment you must log in.
FAILED: Continuous integration, rev:4051 /mir-jenkins. ubuntu. com/job/ mir-ci/ 3057/ /mir-jenkins. ubuntu. com/job/ build-mir/ 4088/console /mir-jenkins. ubuntu. com/job/ build-0- fetch/4175/ console /mir-jenkins. ubuntu. com/job/ build-1- sourcepkg/ release= vivid+overlay/ 4165/console /mir-jenkins. ubuntu. com/job/ build-1- sourcepkg/ release= xenial+ overlay/ 4165/console /mir-jenkins. ubuntu. com/job/ build-1- sourcepkg/ release= zesty/4165/ console /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= amd64,compiler= clang,platform= mesa,release= zesty/4115/ console /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= amd64,compiler= gcc,platform= mesa,release= xenial+ overlay/ 4115/console /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= amd64,compiler= gcc,platform= mesa,release= zesty/4115/ console /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= cross-armhf, compiler= gcc,platform= android, release= vivid+overlay/ 4115/console /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= i386,compiler= gcc,platform= android, release= vivid+overlay/ 4115/console /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= i386,compiler= gcc,platform= mesa,release= xenial+ overlay/ 4115/console
https:/
Executed test runs:
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild: /mir-jenkins. ubuntu. com/job/ mir-ci/ 3057/rebuild
https:/