Mir

Merge lp://staging/~alan-griffiths/mir/configurable-graphicsplatform into lp://staging/~mir-team/mir/trunk

  1. configurable-graphicsplatform
  2. Merge into trunk
Proposed by Alan Griffiths
Status: Merged
Approved by: Kevin DuBois
Approved revision: no longer in the source branch.
Merged at revision: 769
Proposed branch: lp://staging/~alan-griffiths/mir/configurable-graphicsplatform
Merge into: lp://staging/~mir-team/mir/trunk
Prerequisite: lp://staging/~alan-griffiths/mir/dlopen-graphicsplatform
Diff against target: 73 lines (+29/-2)
1 file modified
src/server/default_server_configuration.cpp (+29/-2)
To merge this branch: bzr merge lp://staging/~alan-griffiths/mir/configurable-graphicsplatform
Reviewer Review Type Date Requested Status
Kevin DuBois (community) Approve
Robert Carr (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+170853@code.staging.launchpad.net

Commit message

config: allow graphics platform library to be selected by command-line/config

Description of the change

config: allow graphics platform library to be selected by command-line/config

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:766
http://jenkins.qa.ubuntu.com/job/mir-ci/793/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-saucy-i386-build/996
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-saucy-amd64-build/881
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-saucy-amd64-ci/31/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-vm-ci-build/./distribution=quantal,flavor=amd64/469

Click here to trigger a rebuild:
http://s-jenkins:8080/job/mir-ci/793/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:767
http://jenkins.qa.ubuntu.com/job/mir-ci/794/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-saucy-i386-build/997
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-saucy-amd64-build/882
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-saucy-amd64-ci/32
        deb: http://jenkins.qa.ubuntu.com/job/mir-saucy-amd64-ci/32/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-vm-ci-build/./distribution=quantal,flavor=amd64/470

Click here to trigger a rebuild:
http://s-jenkins:8080/job/mir-ci/794/rebuild

review: Approve (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Interesting approach and probably a good first step.

Though I suspect the final "driver model" needs to be implementable with a pure C API. So maybe it's dangerous to establish a precedent that we load C++ code dynamically. We'd be establishing a C++ ABI when we don't want one, in the end.

Revision history for this message
Robert Carr (robertcarr) wrote :

LGTM. I agree that the "driver model" needs a C API, though I think this is more about correctly supporting mir-on-mir, mir-on-x, etc. Either way

review: Approve
Revision history for this message
Kevin DuBois (kdub) wrote :

lgtm too

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches