Merge lp://staging/~al-maisan/launchpad/partner-expiry-535030 into lp://staging/launchpad
Proposed by
Muharem Hrnjadovic
| Status: | Merged |
|---|---|
| Approved by: | Jeroen T. Vermeulen |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | not available |
| Proposed branch: | lp://staging/~al-maisan/launchpad/partner-expiry-535030 |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
432 lines (+127/-106) 3 files modified
cronscripts/expire-archive-files.py (+3/-3) lib/lp/soyuz/scripts/expire_archive_files.py (+21/-15) lib/lp/soyuz/scripts/tests/test_expire_archive_files.py (+103/-88) |
| To merge this branch: | bzr merge lp://staging/~al-maisan/launchpad/partner-expiry-535030 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jeroen T. Vermeulen (community) | code | Approve | |
|
Review via email:
|
|||
Description of the change
Hello there!
This branch revises the former PPA source/binary expiration script to include
partner archives as well.
Most of the changes are due to the refactoring of the test code making it
possible to "reuse" the majority of the original tests.
Tests to run:
bin/test -vv test_expire_
No "make lint" issues.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good.
We discussed a few minor changes in IRC:
* Use a dict for parameter substitution in those big queries; less brittle as the code continues to evolve.
* Use the "common tests" class as a mixin rather than a fully-functional base class. That way you don't need to tell the test loader not to run it on its own.
Jeroen