VM

Merge lp://staging/~akwm/vm/thread-folding into lp://staging/vm

Proposed by Arik
Status: Merged
Approved by: Uday Reddy
Approved revision: 707
Merged at revision: 848
Proposed branch: lp://staging/~akwm/vm/thread-folding
Merge into: lp://staging/vm
Diff against target: 615 lines (+357/-27) (has conflicts)
5 files modified
lisp/vm-motion.el (+74/-18)
lisp/vm-page.el (+20/-2)
lisp/vm-summary.el (+248/-7)
lisp/vm-vars.el (+13/-0)
lisp/vm-version.el (+2/-0)
Text conflict in lisp/vm-page.el
Text conflict in lisp/vm-summary.el
To merge this branch: bzr merge lp://staging/~akwm/vm/thread-folding
Reviewer Review Type Date Requested Status
Uday Pending
Review via email: mp+29020@code.staging.launchpad.net

Commit message

Add thread folding option to summary view

Description of the change

Adding thread folding to the normal thread view in summary. Options include showing number of threads at root message indicator along with folding on movement. Toggle/Expand/Collapse functions exist for flexibility, and indicator in the first cursor position shows toggle state.

New messages always display, allowing long conversations to take up less space in mailbox yet still remain in focus. Default binding to "T" for toggling thread fold state is simple and obvious. Is option controlled so does not affect summary both when not viewing in thread mode or when it's own master switch is off, i.e. changes here are available but not required.

To post a comment you must log in.
Revision history for this message
Uday Reddy (reddyuday) wrote :

Dear Arik,

Thanks very much for all your good work! I have tested your additions
quite strenusously, and they looked quite solid. So, I have now
merged them into the trunk. I have made a few changes along the way,
including renaming variables/functions. I have also added a page in
the "Summaries" chapter of the info manual. If you look at this page,
you will get a quick summary of the changes I made.

I have logged on Launchpad a few problems that I have found as bug
reports. I will now assign them to you.

I have also added you to the VM development team. I am hoping that
this will enable you to make changes to the trunk and check them in.
If it doesn't allow it, then you can always make a personal branch and
we can merge the changes later.

Cheers,
Uday

Arik writes:

> Arik has proposed merging lp:~akwm/vm/thread-folding into lp:vm.
>
> Requested reviews:
> Uday (uday)
>
>
> Adding thread folding to the normal thread view in summary. Options include
> showing number of threads at root message indicator along with folding on
> movement. Toggle/Expand/Collapse functions exist for flexibility, and indicator
> in the first cursor position shows toggle state.
>
> New messages always display, allowing long conversations to take up less space
> in mailbox yet still remain in focus. Default binding to "T" for toggling
> thread fold state is simple and obvious. Is option controlled so does not
> affect summary both when not viewing in thread mode or when it's own master
> switch is off, i.e. changes here are available but not required.
> --
> https://code.launchpad.net/~akwm/vm/thread-folding/+merge/29020
> You are subscribed to branch lp:vm.
>

Revision history for this message
Uday Reddy (reddyuday) wrote :

Sorry, it looks like the merge didn't get pushed to the Launchpad yet. I will push it tonight from my home computer.

Cheers,
Uday

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: