Project for Service Management

Merge lp://staging/~akretion-team/project-service/project-service-port-functionnal-block into lp://staging/~project-core-editors/project-service/trunk

Proposed by Sébastien BEAU - http://www.akretion.com on 2014-03-20

Status:	Merged
Merged at revision:	34
Proposed branch:	lp://staging/~akretion-team/project-service/project-service-port-functionnal-block
Merge into:	lp://staging/~project-core-editors/project-service/trunk
Diff against target:	376 lines (+122/-76) 8 files modified project_functional_block/__init__.py (+2/-2) project_functional_block/__openerp__.py (+21/-17) project_functional_block/project.py (+49/-22) project_functional_block/project_demo.xml (+21/-0) project_functional_block/project_view.xml (+23/-20) project_functional_block/security/ir.model.access.csv (+2/-2) project_issue_service/project_issue.py (+1/-1) project_task_service/project_task.py (+3/-12)
To merge this branch:	bzr merge lp://staging/~akretion-team/project-service/project-service-port-functionnal-block
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Daniel Reis	lgtm	2014-03-20	Approve on 2014-04-17
Raphaël Valyi - http://www.akretion.com			Approve on 2014-03-21
Review via email: mp+211984@code.staging.launchpad.net

Port project functionnal block to 7 version.

Revision history for this message

Daniel Reis (dreis-pt) wrote on 2014-03-20:

In L203, `colspan="4"`: I can be wrong, but I think in v7 this is ignored.
Otherwise, LGTM.

review: Approve

36. By Sébastien BEAU - http://www.akretion.com on 2014-03-20: [REF] port view on 7

Revision history for this message

Sébastien BEAU - http://www.akretion.com (sebastien.beau) wrote on 2014-03-20:

I clean the view

37. By Sébastien BEAU - http://www.akretion.com on 2014-03-20: [IMP] add demo data
38. By Sébastien BEAU - http://www.akretion.com on 2014-03-20: [REF] rename project_functional_blocks into project_functional_block

Revision history for this message

Sébastien BEAU - http://www.akretion.com (sebastien.beau) wrote on 2014-03-20:

I add some demo data and also I rename the module (remove the useless "s")

Regarding the name of the object "project.functional_block" what is better keeping the "_" ou replacing it by a "."

Thanks

Revision history for this message

Daniel Reis (dreis-pt) wrote on 2014-03-21:

Good question.
I grepped the addons, and IMHO it would be more consistent to use "project.functional.block".

39. By Sébastien BEAU - http://www.akretion.com on 2014-03-21: [REF] rename project.functional_block into project.functional.block

Revision history for this message

Sébastien BEAU - http://www.akretion.com (sebastien.beau) wrote on 2014-03-21:

Done ;)

Revision history for this message

Raphaël Valyi - http://www.akretion.com (rvalyi) wrote on 2014-03-21:

Thanks Seb, seems all right; tested.

review: Approve

40. By David BEAL (ak) on 2014-03-25: [FIX] replace project.functional_block by project.functional.block
41. By David BEAL (ak) on 2014-03-25: [FIX] rename project.functional_block in project.functional.block in roject_task_service
42. By David BEAL (ak) on 2014-03-25: [FIX] rename project.functional_block in project.functional.block in project_issue_service