Merge lp://staging/~akretion-team/openerp-manufacturing/70-add-mrp-product-serial into lp://staging/openerp-manufacturing

Proposed by Alexis de Lattre
Status: Needs review
Proposed branch: lp://staging/~akretion-team/openerp-manufacturing/70-add-mrp-product-serial
Merge into: lp://staging/openerp-manufacturing
Diff against target: 169 lines (+143/-0)
5 files modified
mrp_product_serial/__init__.py (+21/-0)
mrp_product_serial/__openerp__.py (+43/-0)
mrp_product_serial/i18n/fr.po (+21/-0)
mrp_product_serial/i18n/product_serial_mrp.pot (+21/-0)
mrp_product_serial/mrp_view.xml (+37/-0)
To merge this branch: bzr merge lp://staging/~akretion-team/openerp-manufacturing/70-add-mrp-product-serial
Reviewer Review Type Date Requested Status
Joël Grand-Guillaume @ camptocamp code review, no tests Approve
Maxime Chambreuil (http://www.savoirfairelinux.com) Approve
Alexandre Fayolle - camptocamp lgtm Approve
Review via email: mp+211689@code.staging.launchpad.net

Description of the change

This MP adds the module mrp_product_serial. This module depends on mrp and product_serial (from OCA project stock-logistics-flows). It adds the "Spread Serial Numbers" wizard on Manufacturing Orders.

This module require the last version of the product_serial module, which is under review here : https://code.launchpad.net/~akretion-team/stock-logistic-flows/70-product_serial-plus-plus/+merge/195144

To post a comment you must log in.
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

LGTM. I've also reviewed the other MP and it needs fixing

review: Approve (lgtm)
Revision history for this message
Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903) :
review: Approve
Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

LGTM, this other MP is now ok

review: Approve (code review, no tests)

Unmerged revisions

7. By Alexis de Lattre

Add module mrp_product_serial.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches