Merge lp://staging/~akopytov/percona-xtrabackup/bug1175566-2.1 into lp://staging/percona-xtrabackup/2.1

Proposed by Alexey Kopytov
Status: Merged
Approved by: Sergei Glushchenko
Approved revision: no longer in the source branch.
Merged at revision: 594
Proposed branch: lp://staging/~akopytov/percona-xtrabackup/bug1175566-2.1
Merge into: lp://staging/percona-xtrabackup/2.1
Diff against target: 55 lines (+19/-4)
3 files modified
patches/innodb56.patch (+12/-1)
src/innodb_int.h (+5/-1)
src/xtrabackup.cc (+2/-2)
To merge this branch: bzr merge lp://staging/~akopytov/percona-xtrabackup/bug1175566-2.1
Reviewer Review Type Date Requested Status
Sergei Glushchenko (community) g2 Approve
Review via email: mp+162514@code.staging.launchpad.net

Description of the change

    Bug #1175566: Assertion failure in Xtrabackup --stats run on MySQL
    datadir (xtrabackup_56)

    The root cause was http://bugs.mysql.com/bug.php?id=69131 resulting in
    xtrabackup_56 trying to update data files in the read only mode.

    This also fixes a minor issue introduced by the XtraBackup port to
    5.6. In XtraBackup we want to set the initial file format to the minimum
    supported one, rather than the maximum one, to avoid updating the file
    format tag in data files. Currently, that could never lead to any
    user-visible issues, but is still an incorrect thing to do.

http://jenkins.percona.com/view/XtraBackup/job/percona-xtrabackup-2.1-param/296/

To post a comment you must log in.
Revision history for this message
Sergei Glushchenko (sergei.glushchenko) wrote :

Approve

review: Approve (g2)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: