Charm Helpers

Merge lp://staging/~ajkavanagh/charm-helpers/memcache-context-ipv4-support into lp://staging/charm-helpers

  1. memcache-context-ipv4-support
  2. Merge into devel
Proposed by Alex Kavanagh
Status: Merged
Merged at revision: 735
Proposed branch: lp://staging/~ajkavanagh/charm-helpers/memcache-context-ipv4-support
Merge into: lp://staging/charm-helpers
Diff against target: 305 lines (+113/-28)
4 files modified
charmhelpers/contrib/network/ip.py (+10/-0)
charmhelpers/contrib/openstack/context.py (+21/-9)
tests/contrib/network/test_ip.py (+26/-4)
tests/contrib/openstack/test_os_contexts.py (+56/-15)
To merge this branch: bzr merge lp://staging/~ajkavanagh/charm-helpers/memcache-context-ipv4-support
Reviewer Review Type Date Requested Status
James Page Needs Fixing
Review via email: mp+322743@code.staging.launchpad.net

Description of the change

Add ipv4 support to the class MemcacheContext

To post a comment you must log in.
lp://staging/~ajkavanagh/charm-helpers/memcache-context-ipv4-support updated
735. By Alex Kavanagh

Revised version of ipv4 support in the MemcacheContext

This version defaults to ipv6 unless ipv6 is explicitly disabled or
not available. This retains the existing behaviour of defaulting to
ipv6 regardless of the 'prefer-ipv6' setting.

Revision history for this message
James Page (james-page) :
review: Needs Fixing
lp://staging/~ajkavanagh/charm-helpers/memcache-context-ipv4-support updated
736. By Alex Kavanagh

Remove spurious extra line missed during refactor

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches