Merge lp://staging/~ajkavanagh/charm-helpers/fix-alphanumerica-comparisons into lp://staging/charm-helpers

Proposed by Alex Kavanagh
Status: Merged
Merged at revision: 720
Proposed branch: lp://staging/~ajkavanagh/charm-helpers/fix-alphanumerica-comparisons
Merge into: lp://staging/charm-helpers
Diff against target: 28 lines (+6/-2)
2 files modified
charmhelpers/contrib/openstack/utils.py (+5/-1)
tests/contrib/openstack/test_os_utils.py (+1/-1)
To merge this branch: bzr merge lp://staging/~ajkavanagh/charm-helpers/fix-alphanumerica-comparisons
Reviewer Review Type Date Requested Status
Ryan Beisner (community) Approve
Review via email: mp+320358@code.staging.launchpad.net

Description of the change

Improved the error handling of when an item is not in a BasicStringComparator list. This is to improve the experience of the developer when debugging/integrating derived classes from the BasicStringComparator.

To post a comment you must log in.
Revision history for this message
Ryan Beisner (1chb1n) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches