Merge lp://staging/~aisrael/python-jujuclient/python-juju-client into lp://staging/python-jujuclient

Proposed by Adam Israel
Status: Merged
Merged at revision: 68
Proposed branch: lp://staging/~aisrael/python-jujuclient/python-juju-client
Merge into: lp://staging/python-jujuclient
Diff against target: 35 lines (+5/-6)
1 file modified
jujuclient.py (+5/-6)
To merge this branch: bzr merge lp://staging/~aisrael/python-jujuclient/python-juju-client
Reviewer Review Type Date Requested Status
Tim Van Steenburgh (community) Approve
Review via email: mp+284501@code.staging.launchpad.net

Description of the change

This patch fixes an issue where, under python 3.4+, strings needed to be converted from unicode to bytestring and vice versa

To post a comment you must log in.
Revision history for this message
Tim Van Steenburgh (tvansteenburgh) wrote :

LGTM, thanks. I added some tests before commit/pushing.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: