Merge lp://staging/~aisrael/charms/trusty/apache-hadoop-plugin/charms.benchmark into lp://staging/charms/trusty/apache-hadoop-plugin
Proposed by
Adam Israel
Status: | Needs review |
---|---|
Proposed branch: | lp://staging/~aisrael/charms/trusty/apache-hadoop-plugin/charms.benchmark |
Merge into: | lp://staging/charms/trusty/apache-hadoop-plugin |
Diff against target: |
40 lines (+4/-4) 3 files modified
actions/parseTerasort.py (+1/-1) hooks/common.py (+1/-1) resources.yaml (+2/-2) |
To merge this branch: | bzr merge lp://staging/~aisrael/charms/trusty/apache-hadoop-plugin/charms.benchmark |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Kevin W Monroe | Needs Information | ||
Review via email:
|
Description of the change
Replace the deprecated charm-benchmark with charms.benchmark
To post a comment you must log in.
Unmerged revisions
- 104. By Adam Israel
-
Install charms.benchmark instead of the deprecated charm-benchmark
Unfortunately, this won't work for us:
https:/ /github. com/juju- solutions/ charms. benchmark/ blob/master/ setup.py# L6
We're using a fork of charmhelpers that is incompatible with > 0.5.0. Updating the system-level CH to this new version breaks our fork. Could charms.benchmark install its reqs into a .venv and activate that as needed?