Merge lp://staging/~aisrael/charms/precise/juju-gui/fix-automated-testing into lp://staging/charms/juju-gui
| Status: | Superseded |
|---|---|
| Proposed branch: | lp://staging/~aisrael/charms/precise/juju-gui/fix-automated-testing |
| Merge into: | lp://staging/charms/juju-gui |
| Diff against target: |
49 lines (+16/-0) 2 files modified
config.yaml (+4/-0) tests/tests.yaml (+12/-0) |
| To merge this branch: | bzr merge lp://staging/~aisrael/charms/precise/juju-gui/fix-automated-testing |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Francesco Banconi | Approve | ||
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2014-10-13.
Description of the change
This MP addresses the juju-gui charm failing to pass automated testing[1]. Our bundletester[2] runs make lint and make test; make sysdeps wasn't being run (which also misses installing firefox). The download-cache directory is marked executable, which causes the test to fail.
The simplest solution is adding a tests.yaml to the test directory, which directs the bundletester on how to run the test. It handles installing dependencies, directs which executables represent the tests, and skips resetting the environment, since the test handles that.
--
[1] http://
[2] https:/
Hi Adam,
thanks a lot for this branch, it looks nice, with just a minor request below.
Also note that lp:charms/juju-gui is the precise release branch of the GUI charm, while the development branch is lp:~juju-gui/charms/trusty/juju-gui/trunk, which is then pushed to both precise and trusty releases. Could you please repropose this against lp:~juju-gui/charms/trusty/juju-gui/trunk? I will take care of making charm releases later, so that we can test the GUI charm again with the bundletester.