Merge lp://staging/~aisrael/charms/precise/hacluster/fix-charm-proof-lint-test into lp://staging/charms/hacluster
Proposed by
Adam Israel
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~aisrael/charms/precise/hacluster/fix-charm-proof-lint-test |
| Merge into: | lp://staging/charms/hacluster |
| Diff against target: |
74 lines (+13/-3) 4 files modified
Makefile (+7/-2) config.yaml (+3/-0) hooks/hooks.py (+1/-1) metadata.yaml (+2/-0) |
| To merge this branch: | bzr merge lp://staging/~aisrael/charms/precise/hacluster/fix-charm-proof-lint-test |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| charmers | Pending | ||
|
Review via email:
|
|||
Description of the change
Fixed charm proof warnings and make lint/test failures.
To post a comment you must log in.
Unmerged revisions
- 24. By Adam Israel
-
Add categories to metadata.yaml, default: stanzas to config.yaml, and generic icon.svg, in order to pass charm proof
Fixed error in hooks.py so make lint passes
Added virtualenv to Makefile so that make test passes
Added empty unit_test directory so make test passes
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
