Merge lp://staging/~aisrael/charms/precise/glance/charm-proof into lp://staging/~openstack-charmers-archive/charms/precise/glance/trunk

Proposed by Adam Israel
Status: Merged
Merge reported by: James Page
Merged at revision: not available
Proposed branch: lp://staging/~aisrael/charms/precise/glance/charm-proof
Merge into: lp://staging/~openstack-charmers-archive/charms/precise/glance/trunk
Diff against target: 27 lines (+3/-0)
1 file modified
config.yaml (+3/-0)
To merge this branch: bzr merge lp://staging/~aisrael/charms/precise/glance/charm-proof
Reviewer Review Type Date Requested Status
OpenStack Charmers Pending
Review via email: mp+234351@code.staging.launchpad.net

Description of the change

Add default stanzas to config.yaml in order to pass charm proof.

To post a comment you must log in.
Revision history for this message
Edward Hope-Morley (hopem) wrote :

This currently affects most charms and since this type of fix is functionally equivalent I reckon it would make more sense to adjust charm proof to ignore lack of default for string type.

Revision history for this message
José Antonio Rey (jose) wrote :

Edward,

This is setting default as a None value, rather than an empty string, which would be "". It's simply lowering the output message to an informational one instead of an error. I believe it would not conflict with any of the current code.

Revision history for this message
Edward Hope-Morley (hopem) wrote :

Jose, if default: is omitted it has the same effect as if adding it with no value i.e. it produces None as the value of the config parameter (at least that is the behaviour I get with juju-core 1.20.7-0ubuntu1~14.04.1~juju1). So this change has no effect at all other than pacifying charm proof. As a result I think that charm proof should ignore the case where no default is provided since it is a false positive.

Revision history for this message
Corey Bryant (corey.bryant) wrote :

I agree with Edward. If it's possible to improve charm proof, that's the better approach rather than every single charm having to add useless lines to appease the tool. Anyway I can't reproduce this so maybe charm proof has already been updated?

Revision history for this message
Matt Bruzek (mbruzek) wrote :

The whole Ecosystem team is going through older charms increasing their quality to the agreed upon standard. Adding the default: field removes ambiguity for our users and is a good thing. Please voice your objections on the juju mailing list: <email address hidden> so it can be discussed with everyone concerned with Juju, rather than the few people subscribed to this bug report. The juju mailing list contains the people who can be convinced to change the tooling and policy if needed.

Revision history for this message
James Page (james-page) wrote :

Equiv fix landed into /next, release in 2 wks.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches