Prometheus Blackbox Exporter Charm

Merge ~aieri/charm-prometheus-blackbox-exporter:bb-sub into ~prometheus-charmers/charm-prometheus-blackbox-exporter:master

  1. Git
  2. lp:~aieri/charm-prometheus-blackbox-exporter
  3. bb-sub
  4. Merge into master
Proposed by Andrea Ieri
Status: Rejected
Rejected by: Haw Loeung
Proposed branch: ~aieri/charm-prometheus-blackbox-exporter:bb-sub
Merge into: ~prometheus-charmers/charm-prometheus-blackbox-exporter:master
Diff against target: 282 lines (+192/-15)
5 files modified
config.yaml (+7/-0)
layer.yaml (+7/-2)
metadata.yaml (+9/-2)
reactive/prometheus-blackbox-exporter.py (+167/-11)
wheelhouse.txt (+2/-0)
Reviewer Review Type Date Requested Status
Alvaro Uria (community) Disapprove
BootStack Reviewers mr tracking; do not claim Pending
BootStack Reviewers Pending
BootStack Reviewers Pending
Canonical IS Reviewers Pending
Canonical IS Reviewers Pending
Review via email: mp+372592@code.staging.launchpad.net

This proposal supersedes a proposal from 2019-09-06.

Commit message

Blackbox exporter rewritten as subordinate

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote : Posted in a previous version of this proposal

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote : Posted in a previous version of this proposal

Unable to determine commit message from repository - please click "Set commit message" and enter the commit message manually.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Unable to determine commit message from repository - please click "Set commit message" and enter the commit message manually.

Revision history for this message
Alvaro Uria (aluria) wrote :

A new charm needs to be created (ie. prometheus-blackbox-peer-exporter) for this MP. The current charm is non-subordinate and used by IS, while the current fix makes the charm a subordinate.

I will talk to JL to create that new charm and create MPs against it.

review: Disapprove

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches