Merge ~aieri/charm-hw-health:oo-rewrite-cleanup1 into ~nagios-charmers/charm-hw-health:oo-rewrite-integration
Proposed by
Andrea Ieri
| Status: | Merged |
|---|---|
| Merge reported by: | Andrea Ieri |
| Merged at revision: | 1491ade61e510ea58cbb9fb233aa792037d78e25 |
| Proposed branch: | ~aieri/charm-hw-health:oo-rewrite-cleanup1 |
| Merge into: | ~nagios-charmers/charm-hw-health:oo-rewrite-integration |
| Prerequisite: | ~aieri/charm-hw-health:oo-rewrite-core |
| Diff against target: |
385 lines (+7/-133) 2 files modified
dev/null (+0/-133) src/config.yaml (+7/-0) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Stuart Bishop (community) | Approve | ||
| Alvaro Uria | Pending | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2019-03-19.
Description of the change
Part 3 of the superseded MR#364694
To post a comment you must log in.
Revision history for this message
| Andrea Ieri (aieri) wrote | # |
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good, but in this case I think it is better to use a > yaml string instead of |, as the latter is for pre-formatted text that needs to preserve newlines.