Ubuntu Weather App

Merge lp://staging/~ahayzen/ubuntu-weather-app/fix-1485657-flaky-test into lp://staging/ubuntu-weather-app

  1. fix-1485657-flaky-test
  2. Merge into reboot
Proposed by Andrew Hayzen
Status: Merged
Approved by: Victor Thompson
Approved revision: 96
Merged at revision: 98
Proposed branch: lp://staging/~ahayzen/ubuntu-weather-app/fix-1485657-flaky-test
Merge into: lp://staging/ubuntu-weather-app
Diff against target: 78 lines (+11/-10)
3 files modified
debian/changelog (+1/-0)
po/com.ubuntu.weather.pot (+8/-8)
tests/autopilot/ubuntu_weather_app/__init__.py (+2/-2)
To merge this branch: bzr merge lp://staging/~ahayzen/ubuntu-weather-app/fix-1485657-flaky-test
Reviewer Review Type Date Requested Status
Victor Thompson Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+268250@code.staging.launchpad.net

Commit message

* Fix for flaky test as get_location does not wait for location to be loaded

Description of the change

* Fix for flaky test as get_location does not wait for location to be loaded

This fixes a flaky test that was found while testing other AP branches, basically the location can take a while to appear on slower connections in the list so that select_single should be a wait_select_single.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:96
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/212/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-utopic-amd64-ci/182
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-vivid-amd64-ci/212

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/212/rebuild

review: Approve (continuous-integration)
Revision history for this message
Victor Thompson (vthompson) wrote :

Did you discover this by running the tests on a 3G network? I assume you ran the full suite? It'd be nice if we could catch all such instances.

review: Needs Information
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

This was found on a slow copper connection :-) I ran the test suite multiple times and the only failing test/helper was this method.

I'll put a traffic shaper on my network to simulate an even slower network and put any further fixes into a second MP, from what I could see this was the only failing test though.

Revision history for this message
Victor Thompson (vthompson) wrote :

Sounds great. This lgtm!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: