ubuntu-system-settings

Merge lp://staging/~ahayzen/ubuntu-system-settings/printers-use-header-sections into lp://staging/~jonas-drange/ubuntu-system-settings/printers

  1. printers-use-header-sections
  2. Merge into printers
Proposed by Andrew Hayzen
Status: Merged
Approved by: Jonas G. Drange
Approved revision: 1778
Merged at revision: 1777
Proposed branch: lp://staging/~ahayzen/ubuntu-system-settings/printers-use-header-sections
Merge into: lp://staging/~jonas-drange/ubuntu-system-settings/printers
Diff against target: 156 lines (+56/-46)
3 files modified
plugins/printing/PageComponent.qml (+5/-1)
plugins/printing/Printer.qml (+45/-45)
src/qml/MainWindow.qml (+6/-0)
To merge this branch: bzr merge lp://staging/~ahayzen/ubuntu-system-settings/printers-use-header-sections
Reviewer Review Type Date Requested Status
Jonas G. Drange Approve
Review via email: mp+320679@code.staging.launchpad.net

Commit message

* Change subPageSelector to be header sections
* Disable automatic height of the standard and search headers
* Fix Printers list and Describe Printer not being scrollable

Description of the change

* Change subPageSelector to be header sections
* Disable automatic height of the standard and search headers
* Fix Printers list and Describe Printer not being scrollable

To post a comment you must log in.
lp://staging/~ahayzen/ubuntu-system-settings/printers-use-header-sections updated
1777. By Andrew Hayzen

* Fix scrolling not functioning on the printer list page

1778. By Andrew Hayzen

* Fix for AddPrinterDetails.qml not scrolling

Revision history for this message
Jonas G. Drange (jonas-drange) wrote :

LGTM! Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: