Ubuntu Music App

Merge lp://staging/~ahayzen/music-app/refactor-improve-current-file-restore-2 into lp://staging/music-app

  1. refactor-improve-current-file-restore-2
  2. Merge into trunk
Proposed by Andrew Hayzen
Status: Merged
Approved by: Victor Thompson
Approved revision: 857
Merged at revision: 854
Proposed branch: lp://staging/~ahayzen/music-app/refactor-improve-current-file-restore-2
Merge into: lp://staging/music-app
Diff against target: 16 lines (+2/-2)
1 file modified
app/components/Player.qml (+2/-2)
To merge this branch: bzr merge lp://staging/~ahayzen/music-app/refactor-improve-current-file-restore-2
Reviewer Review Type Date Requested Status
Victor Thompson Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+257711@code.staging.launchpad.net

Commit message

* Only autoset the source due to queue count changes when the queue worker has completed

Description of the change

* Only autoset the source due to queue count changes when the queue worker has completed

To post a comment you must log in.
Revision history for this message
Victor Thompson (vthompson) wrote :

lgtm!

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/music-app-refactor-autolanding/28/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2673
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2673/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-refactor-utopic-amd64-autolanding/14
    SUCCESS: http://91.189.93.70:8080/job/music-app-refactor-vivid-amd64-autolanding/28

review: Needs Fixing (continuous-integration)
lp://staging/~ahayzen/music-app/refactor-improve-current-file-restore-2 updated
857. By Andrew Hayzen

* Don't check if completed if it cannot load

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:857
http://91.189.93.70:8080/job/music-app-refactor-ci/68/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2674
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2674/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-refactor-utopic-amd64-ci/26
    SUCCESS: http://91.189.93.70:8080/job/music-app-refactor-vivid-amd64-ci/68

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-refactor-ci/68/rebuild

review: Approve (continuous-integration)
Revision history for this message
Victor Thompson (vthompson) wrote :

lgtm! thanks for the quick turnaround!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches