Ubuntu Music App

Merge lp://staging/~ahayzen/music-app/refactor-fix-1435658-close-dialog-before-pop into lp://staging/music-app

  1. refactor-fix-1435658-close-dialog-before-pop
  2. Merge into trunk
Proposed by Andrew Hayzen
Status: Merged
Approved by: Victor Thompson
Approved revision: 848
Merged at revision: 848
Proposed branch: lp://staging/~ahayzen/music-app/refactor-fix-1435658-close-dialog-before-pop
Merge into: lp://staging/music-app
Diff against target: 130 lines (+23/-8)
6 files modified
app/components/HeadState/PlaylistsHeadState.qml (+1/-1)
app/components/MusicPage.qml (+2/-0)
app/components/Walkthrough/FirstRunWalkthrough.qml (+1/-1)
app/music-app.qml (+14/-1)
app/ui/NowPlaying.qml (+1/-1)
app/ui/SongsView.qml (+4/-4)
To merge this branch: bzr merge lp://staging/~ahayzen/music-app/refactor-fix-1435658-close-dialog-before-pop
Reviewer Review Type Date Requested Status
Victor Thompson Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+254016@code.staging.launchpad.net

Commit message

* Ensure dialogs are closed before popping a page

Description of the change

* Ensure dialogs are closed before popping a page

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:847
http://91.189.93.70:8080/job/music-app-refactor-ci/52/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2417
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2417/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-refactor-utopic-amd64-ci/10
    SUCCESS: http://91.189.93.70:8080/job/music-app-refactor-vivid-amd64-ci/52

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-refactor-ci/52/rebuild

review: Approve (continuous-integration)
lp://staging/~ahayzen/music-app/refactor-fix-1435658-close-dialog-before-pop updated
848. By Andrew Hayzen

* Ensure all pageStack.pop()'s use mainPageStack.goBack() instead

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:848
http://91.189.93.70:8080/job/music-app-refactor-ci/53/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2418
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2418/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-refactor-utopic-amd64-ci/11
    SUCCESS: http://91.189.93.70:8080/job/music-app-refactor-vivid-amd64-ci/53

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-refactor-ci/53/rebuild

review: Approve (continuous-integration)
Revision history for this message
Victor Thompson (vthompson) wrote :

LGTM! Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches