Ubuntu Music App

app/components/Helpers/ContentHubHelper.qml (+55/-45)
app/components/Helpers/UriHandlerHelper.qml (+13/-1)
app/logic/stored-request.js (+33/-0)
app/music-app.qml (+7/-0)

To merge this branch:

bzr merge lp://staging/~ahayzen/music-app/refactor-delay-urlhandler-contenthub-after-walkthrough

Medium

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Victor Thompson		2015-03-31	Approve on 2015-04-06
Ubuntu Phone Apps Jenkins Bot	continuous-integration		Approve on 2015-04-06
Review via email: mp+254760@code.staging.launchpad.net

Commit message

* Delay urlhandler/content-hub calls until after walkthrough is complete

Description of the change

* Delay urlhandler/content-hub calls until after walkthrough is complete

Refactor compliment to [0] same testing please :)

0 - https://code.launchpad.net/~ahayzen/music-app/fix-1438317-delay-urlhandler-contenthub-after-walkthrough/+merge/254756

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2015-03-31:

PASSED: Continuous integration, rev:850
http://91.189.93.70:8080/job/music-app-refactor-ci/56/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2469
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2469/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-refactor-utopic-amd64-ci/14
    SUCCESS: http://91.189.93.70:8080/job/music-app-refactor-vivid-amd64-ci/56

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-refactor-ci/56/rebuild

review: Approve (continuous-integration)

lp://staging/~ahayzen/music-app/refactor-delay-urlhandler-contenthub-after-walkthrough updated on 2015-04-03

851. By Andrew Hayzen on 2015-04-03: * Only store the last request
* Use a generic external request store
852. By Andrew Hayzen on 2015-04-03: * Remove unused vars

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2015-04-03:

PASSED: Continuous integration, rev:852
http://91.189.93.70:8080/job/music-app-refactor-ci/57/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2490
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2490/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-refactor-utopic-amd64-ci/15
    SUCCESS: http://91.189.93.70:8080/job/music-app-refactor-vivid-amd64-ci/57

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-refactor-ci/57/rebuild

review: Approve (continuous-integration)

lp://staging/~ahayzen/music-app/refactor-delay-urlhandler-contenthub-after-walkthrough updated on 2015-04-03

853. By Andrew Hayzen on 2015-04-03: * Add wait for queueLoaderWorker in processAlbum()

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2015-04-04:

PASSED: Continuous integration, rev:853
http://91.189.93.70:8080/job/music-app-refactor-ci/58/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2492
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2492/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-refactor-utopic-amd64-ci/16
    SUCCESS: http://91.189.93.70:8080/job/music-app-refactor-vivid-amd64-ci/58

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-refactor-ci/58/rebuild

review: Approve (continuous-integration)

Revision history for this message

Victor Thompson (vthompson) wrote on 2015-04-04:

It seems a little odd to have a helper component just to store a function to be called later--but I'm OK with it. Would it make more sense to use a JS library or something?

import "external-request.js" as ExternalRequest

I'll try to do some testing a bit later on.

review: Needs Information

lp://staging/~ahayzen/music-app/refactor-delay-urlhandler-contenthub-after-walkthrough updated on 2015-04-05