Code review comment for ~ahasenack/ubuntu/+source/nfs-utils:kinetic-nfsutils-merge

Review is ok, but testing is not entirely clean.

Updating a Kinetic system to your PPA gave me:

Setting up nfs-kernel-server (1:2.6.1-2ubuntu1~ppa5) ...
nfs-mountd.service is a disabled or a static unit not running, not starting it.
nfsdcld.service is a disabled or a static unit not running, not starting it.
Could not execute systemctl: at /usr/bin/deb-systemd-invoke line 145.
A dependency job for nfs-server.service failed. See 'journalctl -xe' for details.
invoke-rc.d: initscript nfs-kernel-server, action "restart" failed.
○ nfs-server.service - NFS server and services
     Loaded: loaded (/lib/systemd/system/nfs-server.service; enabled; vendor preset: enabled)
     Active: inactive (dead)

Jun 28 12:42:40 k systemd[1]: Dependency failed for NFS server and services.
Jun 28 12:42:40 k systemd[1]: nfs-server.service: Job nfs-server.service/start failed with result 'dependency'.
Jun 28 12:42:40 k systemd[1]: Dependency failed for NFS server and services.
Jun 28 12:42:40 k systemd[1]: nfs-server.service: Job nfs-server.service/start failed with result 'dependency'.
Jun 28 12:53:09 k systemd[1]: Dependency failed for NFS server and services.
Jun 28 12:53:09 k systemd[1]: nfs-server.service: Job nfs-server.service/start failed with result 'dependency'.
Jun 28 12:53:09 k systemd[1]: Dependency failed for NFS server and services.
Jun 28 12:53:09 k systemd[1]: nfs-server.service: Job nfs-server.service/start failed with result 'dependency'.
Failed to restart nfs-kernel-server, ignoring.

That didn't happen in all environments.
And it is rather obvious.
It is due to nfsd failing

root@k:~# systemctl status proc-fs-nfsd.mount
× proc-fs-nfsd.mount - NFSD configuration filesystem
     Loaded: loaded (/lib/systemd/system/proc-fs-nfsd.mount; static)
     Active: failed (Result: exit-code) since Tue 2022-06-28 12:53:09 UTC; 4min 6s ago
      Where: /proc/fs/nfsd
       What: nfsd

Jun 28 12:53:09 k mount[133913]: mount: /proc/fs/nfsd: permission denied.

As it is in a LXD container

I wonder if we should add a Condition or some other softening hint to make this less complaining.
OTOH - this will almost never work in a container unless you seriously modify its isolation, so since it is not fatal it might be right to complain a bit on install/upgrade.

Up to you to decide

Review complete LGTM +1