Merge ~ahasenack/ubuntu/+source/bind9:lunar-bind9-dyndb-ldap-dep8 into ubuntu/+source/bind9:ubuntu/lunar-devel

Proposed by Andreas Hasenack
Status: Merged
Approved by: git-ubuntu bot
Approved revision: not available
Merge reported by: Andreas Hasenack
Merged at revision: 7a48082ff650ac1377775df1628cbef8078308c7
Proposed branch: ~ahasenack/ubuntu/+source/bind9:lunar-bind9-dyndb-ldap-dep8
Merge into: ubuntu/+source/bind9:ubuntu/lunar-devel
Diff against target: 317 lines (+295/-0)
3 files modified
debian/changelog (+6/-0)
debian/tests/control (+9/-0)
debian/tests/dyndb-ldap (+280/-0)
Reviewer Review Type Date Requested Status
git-ubuntu bot Approve
Lucas Kanashiro (community) Approve
Canonical Server Reporter Pending
Review via email: mp+450698@code.staging.launchpad.net

Description of the change

Add a bind-dyndb-ldap DEP8 test to bind9, to prevent a bug like https://bugs.launchpad.net/ubuntu/+source/bind-dyndb-ldap/+bug/1978849 from happening again.

The relationship between src:bind9 and src:bind-dyndb-ldap is such that a simple no-change rebuild of src:bind9 requires a rebuild of src:bind-dyndb-ldap. This DEP8 test will not only check that both can be installed together, which tests the dependency can be satisfied, but also that the ldap plugin from src:bind-dyndb-ldap works. Details in https://bugs.launchpad.net/ubuntu/+source/bind-dyndb-ldap/+bug/1978849/comments/10 and later comments.

PPA: https://launchpad.net/~ahasenack/+archive/ubuntu/bind9-dyndb-ldap/+packages
DEP8: green locally, will trigger in the ppa once all builds are finished

The same test is being added to src:bind-dyndb-ldap.

Note the bug has a block-proposed tag for lunar (and jammy), so that it only gets released together with another SRU that is not DEP8-only.

I will send this to debian as well.

To post a comment you must log in.
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

LGTM, +1.

review: Approve
Revision history for this message
git-ubuntu bot (git-ubuntu-bot) wrote :

Approvers: ahasenack, lucaskanashiro
Uploaders: ahasenack, lucaskanashiro
MP auto-approved

review: Approve
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

This was released already.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches