Merge ~ahasenack/ubuntu/+source/base-files:xenial-handle-was-removed-1895302 into ubuntu/+source/base-files:ubuntu/xenial-devel
Proposed by
Andreas Hasenack
Status: | Approved |
---|---|
Approved by: | Andreas Hasenack |
Approved revision: | 6ca97cfce91cc40d8fbf6c5a61f487c5c2659f43 |
Proposed branch: | ~ahasenack/ubuntu/+source/base-files:xenial-handle-was-removed-1895302 |
Merge into: | ubuntu/+source/base-files:ubuntu/xenial-devel |
Diff against target: |
64 lines (+25/-7) 3 files modified
debian/changelog (+14/-0) debian/motd-news-config.postinst (+1/-1) debian/postinst.in (+10/-6) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Bryce Harrington (community) | Approve | ||
Canonical Server Core Reviewers | Pending | ||
Review via email: mp+390865@code.staging.launchpad.net |
Description of the change
Same as https:/
Linked SRU bug has the template filled out, including a test case.
PPA: https:/
To post a comment you must log in.
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
44d97359a4f73ca d77e9bf30b0c1bd 21b4d4c732
- Seems a reasonable solution.
- I'm curious if you tried dpkg -s ubuntu-server and found that the -l option with grep was better?
989427c706c8689 17534627390bca6 b28baeeb55
- LGTM. Much cleaner looking and likely more maintainable.
29622498abfe7ed 935eacc9abefd47 6505e4e34c
- Do I understand correctly that this differentiates between installs vs. upgrades by $2 being non-blank? If so, is it 100% guaranteed that this is always blank on install?
52a955f23051e29 7070e594d78e894 36b3a1c893
- LGTM
6ca97cfce91cc40 d8fbf6c5a61f487 c5c2659f43
- Changelog looks good.
A couple questions just to clarify some assumptions. Otherwise, looks good.
If you'd like me to run the test cases before you land this, I can do that tomorrow.