Merge ~ahasenack/qa-regression-testing:ndctl-mir-tests into qa-regression-testing:master
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | bb1214cf8cfe26d42a7ada152f015b0942cf760e | ||||
| Proposed branch: | ~ahasenack/qa-regression-testing:ndctl-mir-tests | ||||
| Merge into: | qa-regression-testing:master | ||||
| Diff against target: |
468 lines (+429/-0) 3 files modified
notes_testing/ndctl/README.txt (+140/-0) scripts/test-ndctl.py (+285/-0) scripts/testlib.py (+4/-0) |
||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Steve Beattie (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
ndctl has an approved MIR (https:/
More tests can be added, but the last ones are more complex and will take a bit more time to implement, and I want to get early eyes on this. Furthermore, I think this is already good coverage, and the remaining tests can be added incrementally.
In order to run these tests, a special VM needs to be created, with emulated NVDIMM hardware support. Instructions were added to notes_testing/
These tests were originally done as DEP8 by Rafael Tinoco and copied from the upstream test suite, copyright Intel. I added links to each source for each test. The "conversion", if you will, to python, was done by me. Please advise on copyright statements and licensing issues.
| Steve Beattie (sbeattie) wrote | # |
| Steve Beattie (sbeattie) wrote | # |
| Andreas Hasenack (ahasenack) wrote | # |
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
This is looking great to me. Was able to reprocude the setup with uvt rather than multipass. Happy to merge whenever you think it's ready. Some minor inline comments follow.