Merge ~ahasenack/qa-regression-testing:apache-2.4.33-wont-start-ssl-compression into qa-regression-testing:master
Status: | Merged |
---|---|
Merged at revision: | dfe329df90023fc6c82275ac9c77d87617413f29 |
Proposed branch: | ~ahasenack/qa-regression-testing:apache-2.4.33-wont-start-ssl-compression |
Merge into: | qa-regression-testing:master |
Diff against target: |
36 lines (+24/-1) 1 file modified
scripts/test-apache2.py (+24/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Steve Beattie (community) | Approve | ||
Review via email: mp+345557@code.staging.launchpad.net |
Commit message
Cope with apache 2.4.32 and higher no longer starting when ssl compression is requested but not provided by openssl.
Description of the change
I'm updating cosmic's apache from 2.4.29 to 2.4.33 and this triggered a test error in qa-regression-
=======
FAIL: test_cve_
Test CVE-2012-4929 (compression on)
-------
Traceback (most recent call last):
File "scripts/
File "/home/
self.
File "/home/
self._restart()
File "/home/
self._start()
File "/home/
self.
AssertionError: Got exit code 1, expected 0
Starting apache2 (via systemctl): apache2.serviceJob for apache2.service failed because the control process exited with error code.
See "systemctl status apache2.service" and "journalctl -xe" for details.
failed!
What happened there is that since apache 2.4.32 (see http://
The test suite adds "SSLCompression on" to the default site, then calls _prepare_ssl() which will eventually restart apache. The restart action is guarded by an "apachectl -t" call, which fails because of the above reason, failing the whole test.
I've seen that there are some exceptions in test_cve_
This patch will catch the failure in _prepare_ssl() and check if apachectl -t failed because of this problem. If that's the case, the test is skipped (should it succeed instead?) with a message. If apachectl succeeds, or fails for a different reason, then the original exception from _prepare_ssl() is raised and the test fails.
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Looks good to me, merged. Thanks!