Merge lp://staging/~ahasenack/lazr-js/lazr-js-packaging into lp://staging/~landscape/lazr-js/trunk

Proposed by Andreas Hasenack
Status: Merged
Approved by: Gavin Panella
Approved revision: 184
Merged at revision: 190
Proposed branch: lp://staging/~ahasenack/lazr-js/lazr-js-packaging
Merge into: lp://staging/~landscape/lazr-js/trunk
Diff against target: 135 lines (+105/-0)
6 files modified
debian/changelog (+23/-0)
debian/compat (+1/-0)
debian/control (+30/-0)
debian/copyright (+40/-0)
debian/pycompat (+1/-0)
debian/rules (+10/-0)
To merge this branch: bzr merge lp://staging/~ahasenack/lazr-js/lazr-js-packaging
Reviewer Review Type Date Requested Status
Gavin Panella (community) Approve
Landscape Pending
Review via email: mp+47104@code.staging.launchpad.net

Description of the change

This branch introduces the debian/ directory for packaging. Had to struggle a bit with debian/changelog and recipes, which is what is being used to build this and put it in the lds-trunk PPA for now, where you can see a sample build.

To post a comment you must log in.
Revision history for this message
Gavin Panella (allenap) wrote :

Andreas, I am a packaging newb :) How do I get this to do something for me?

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

What do you want? To build a package, just run "debuild" inside the extracted directory. But I believe there is a package already in ubuntu for txaws.

Revision history for this message
Gavin Panella (allenap) wrote :

Thanks Andreas :)

> But I believe there is a package already in ubuntu for txaws.

This is lazr-js... or am I missing something?

On running debuild I get the following question:

{{{
This package has a Debian revision number but there does not seem to be
an appropriate original tar file or .orig directory in the parent directory;
(expected one of python-lazr-js_1.5-0~bzr183.orig.tar.gz, python-lazr-js_1.5-0~bzr183.orig.tar.bz2,
python-lazr-js_1.5-0~bzr183.orig.tar.lzma, python-lazr-js_1.5-0~bzr183.orig.tar.xz or ahasenack--lazr-js-packaging.orig)
continue anyway? (y/n) y
}}}

If I continue, it eventually fails with:

{{{
Now signing changes and any dsc files...
 signfile python-lazr-js_1.5-0~bzr183-1.dsc Andreas Hasenack <email address hidden>
gpg: skipped "Andreas Hasenack <email address hidden>": secret key not available
gpg: /tmp/debsign.3uOGkH2M/python-lazr-js_1.5-0~bzr183-1.dsc: clearsign failed: secret key not available
debsign: gpg error occurred! Aborting....
debuild: fatal error at line 1258:
running debsign failed
}}}

Any ideas?

review: Needs Information
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Oh, sorry about the txaws comment :)

Yes, add -kyouremail to the debuild command. Like:
debuild -<email address hidden>

Or add -uc -us to skip the signing process.

Revision history for this message
Gavin Panella (allenap) wrote :

This installs fine and the scripts all seems to work okay. The only
downside I can see is that the lazr.js Python stuff can only be
imported using pkg_resources. That's not a major problem but feels a
bit wonky. If you happen to know how to fix this it would be cool, but
if not then I think it's okay to land as is.

review: Approve
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

I have no idea what pkg_resources is :)

Is this a case of a blind person leading the blind? :)

Revision history for this message
Gavin Panella (allenap) wrote :

Who <bumps head> turned out the lights?

I'll ask someone else to take a look at this :)

Revision history for this message
Gavin Panella (allenap) wrote :

I emailed internally for someone else to review this but no one has come forward, so let's just land it and move on.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches