Merge lp://staging/~ahasenack/landscape-client-charm/ci-test-makefile-target into lp://staging/landscape-client-charm
Proposed by
Andreas Hasenack
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Andreas Hasenack | ||||
| Approved revision: | 67 | ||||
| Merged at revision: | 61 | ||||
| Proposed branch: | lp://staging/~ahasenack/landscape-client-charm/ci-test-makefile-target | ||||
| Merge into: | lp://staging/landscape-client-charm | ||||
| Diff against target: |
49 lines (+17/-1) 3 files modified
Makefile (+6/-0) dev/ubuntu-deps (+10/-0) hooks/common.py (+1/-1) |
||||
| To merge this branch: | bzr merge lp://staging/~ahasenack/landscape-client-charm/ci-test-makefile-target | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Alberto Donato | Approve | ||
| Simon Poirier (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Add a ci-test makefile target that will run the tests and install any needed dependencies before.
Description of the change
Add a ci-test makefile target that will run the tests and install any needed dependencies before.
I also changed a print call to a function just to make lint happy. I'm not sure why we are using print there instead of a normal log call, but I didn't want to touch that in this branch.
To post a comment you must log in.
Revision history for this message
| Adam Collard (adam-collard) | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
+1 looks all good and runs fine on clean containers