Stock and Logistic - Reports

Merge lp://staging/~agilebg/stock-logistic-report/adding_delivery_slip_7 into lp://staging/stock-logistic-report

  1. adding_delivery_slip_7
  2. Merge into 7.0
Proposed by Lorenzo Battistini
Status: Merged
Merged at revision: 4
Proposed branch: lp://staging/~agilebg/stock-logistic-report/adding_delivery_slip_7
Merge into: lp://staging/stock-logistic-report
Diff against target: 209 lines (+142/-2)
4 files modified
stock_picking_webkit/__openerp__.py (+8/-2)
stock_picking_webkit/report.xml (+9/-0)
stock_picking_webkit/report/delivery_slip.mako (+97/-0)
stock_picking_webkit/report/stock_report.py (+28/-0)
To merge this branch: bzr merge lp://staging/~agilebg/stock-logistic-report/adding_delivery_slip_7
Reviewer Review Type Date Requested Status
Guewen Baconnier @ Camptocamp code review Approve
Yannick Vaucher @ Camptocamp code review, test Approve
Leonardo Pistone Approve
Review via email: mp+185048@code.staging.launchpad.net
To post a comment you must log in.
lp://staging/~agilebg/stock-logistic-report/adding_delivery_slip_7 updated
11. By Leonardo Pistone

[imp] delivery slip: pep8

Revision history for this message
Leonardo Pistone (lepistone) wrote :

LGTM (committed a bit of pep8 myself)

review: Approve
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

Could the __openerp__.py be improved as you added a report?

Otherwise I tested and code LGTM

Thanks

review: Needs Fixing
lp://staging/~agilebg/stock-logistic-report/adding_delivery_slip_7 updated
12. By Lorenzo Battistini

[IMP] module description

13. By Lorenzo Battistini

[IMP] module name

Revision history for this message
Lorenzo Battistini (elbati) wrote :

On 10/17/2013 11:59 AM, Yannick Vaucher @ Camptocamp wrote:
> Review: Needs Fixing
>
> Could the __openerp__.py be improved as you added a report?

Done.
Thanks

Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

Thanks

I tested and printed the report it looks fine

review: Approve (code review, test)
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

LGTM

Thanks

review: Approve (code review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches