Merge lp://staging/~agateau/unity-2d/gschema-cleanup into lp://staging/unity-2d/3.0
Proposed by
Aurélien Gâteau
Status: | Rejected |
---|---|
Rejected by: | Florian Boucault |
Proposed branch: | lp://staging/~agateau/unity-2d/gschema-cleanup |
Merge into: | lp://staging/unity-2d/3.0 |
Diff against target: |
83 lines (+28/-26) 2 files modified
CMakeLists.txt (+1/-26) data/CMakeLists.txt (+27/-0) |
To merge this branch: | bzr merge lp://staging/~agateau/unity-2d/gschema-cleanup |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Florian Boucault (community) | Disapprove | ||
Review via email:
|
Commit message
[buildsystem] gsettings cleanup:
- Created a data/CMakeLists.txt file to hold cmake commands which are specific to this dir: avoids cluttering the top-level CMakeLists.txt file
- Do not create output file in source dir
Description of the change
This branch moves all the gsettings CMake code to the data/ dir to keep the toplevel CMakeLists.txt short. It also takes care of not generating files in the source dir.
To post a comment you must log in.
Unmerged revisions
- 643. By Aurélien Gâteau
-
[buildsystem] gsettings cleanup:
- Created a data/CMakeLists.txt file to hold cmake commands which are specific
to this dir: avoids cluttering the top-level CMakeLists.txt file
- Do not create output file in source dir
I think it never got merged because it prevented people from running unity 2D uninstalled when doing schema changes.