Merge lp://staging/~agateau/ubiquity/fix-keyboard-variant-combobox into lp://staging/ubiquity

Proposed by Aurélien Gâteau
Status: Merged
Merged at revision: 4953
Proposed branch: lp://staging/~agateau/ubiquity/fix-keyboard-variant-combobox
Merge into: lp://staging/ubiquity
Diff against target: 78 lines (+8/-44)
1 file modified
gui/qt/stepKeyboardConf.ui (+8/-44)
To merge this branch: bzr merge lp://staging/~agateau/ubiquity/fix-keyboard-variant-combobox
Reviewer Review Type Date Requested Status
Achim Bohnet (community) tested the patch Approve
Ubuntu Installer Team Pending
Review via email: mp+76011@code.staging.launchpad.net

Description of the change

Move the keyboard variant combobox to its own line, making it possible to see large content in it.

Note that I haven't tested this, I just adjusted the .ui file. Someone with the necessary setup to test Ubiquity must give it a try.

To post a comment you must log in.
Revision history for this message
Achim Bohnet (allee) wrote :

Patch solves the problem for me.

Test: todays Oneiric Kubuntu live CD in virtualbox: Patched /usr/share/ubiquity/qt/setKeyboardConf.ui with the preview diff and started the installation.

The patched ubiquity shows now for the german installation the full name of the english variants.
After install and reboot. A german installation with english keyboard setting as installed.

So the problem is IMHO solved.

review: Approve (teste the patch)
Revision history for this message
Achim Bohnet (allee) :
review: Approve (tested the patch)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: