Merge ~afreiberger/charm-prometheus-openstack-exporter:lint-20.08 into charm-prometheus-openstack-exporter:master
Proposed by
Drew Freiberger
| Status: | Merged |
|---|---|
| Merged at revision: | b3ee7dea8c6dc564b7ea5ffd773f18aa022b8c01 |
| Proposed branch: | ~afreiberger/charm-prometheus-openstack-exporter:lint-20.08 |
| Merge into: | charm-prometheus-openstack-exporter:master |
| Prerequisite: | ~afreiberger/charm-prometheus-openstack-exporter:blacken-20.08 |
| Diff against target: |
133 lines (+27/-5) 5 files modified
src/hooks/relations/keystone-credentials/requires.py (+3/-1) src/reactive/openstack_exporter.py (+6/-0) src/tests/unit/__init__.py (+1/-0) src/tests/unit/test_reactive_openstack_exporter.py (+10/-1) src/tox.ini (+7/-3) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Xav Paice (community) | Approve | ||
|
Review via email:
|
|||
To post a comment you must log in.
Revision history for this message
| Drew Freiberger (afreiberger) wrote | # |
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I added hooks/relations to ignore because someone has injected those two interfaces into this charm. that should be undone instead of fixing lint on those directories.