Mir

Merge lp://staging/~afrantzis/mir/fix-out-of-order-buffers-1216472 into lp://staging/mir

fix-out-of-order-buffers-1216472
Merge into development-branch

Proposed by Alexandros Frantzis on 2013-09-26

Status:

Merged

Approved by:

Daniel van Vugt on 2013-09-30

Approved revision:

no longer in the source branch.

Merged at revision:

1095

Proposed branch:

lp://staging/~afrantzis/mir/fix-out-of-order-buffers-1216472

Merge into:

lp://staging/mir

Diff against target:

187 lines (+78/-29)

3 files modified

include/server/mir/frontend/session_mediator.h (+7/-2)
src/server/frontend/session_mediator.cpp (+33/-27)
tests/unit-tests/frontend/test_session_mediator.cpp (+38/-0)

To merge this branch:

bzr merge lp://staging/~afrantzis/mir/fix-out-of-order-buffers-1216472

Critical

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot (community)	continuous-integration		Approve on 2013-09-27
Alan Griffiths			Approve on 2013-09-27
Daniel van Vugt			Approve on 2013-09-27
Kevin DuBois (community)		2013-09-26	Needs Information on 2013-09-27
Review via email: mp+187841@code.staging.launchpad.net

This proposal supersedes a proposal from 2013-09-26.

Commit message

Properly track buffers per-surface (not per session). Failure to do so was
causing premature buffer release and re-use in cases with multiple surfaces
per client/session. In XMir this was seen as out of order, glitchy and slow
frames when using multiple monitors (LP: #1216472)

Description of the change

frontend: Properly track buffers per-surface (not per session)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-09-26:

FAILED: Continuous integration, rev:1091
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~afrantzis/mir/fix-out-of-order-buffers-1216472/+merge/187841/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-ci/40/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-saucy-i386-build/2153
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-saucy-amd64-build/2038
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-saucy-amd64-ci/40
        deb: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-saucy-amd64-ci/40/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins:8080/job/mir-team-mir-development-branch-ci/40/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Kevin DuBois (kdub) wrote on 2013-09-27:

change looks good to me.

I don't understand why that would cause the lag, so I couldn't reason through whether this would affect internal clients as well... will mark 'needs info'

review: Needs Information

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2013-09-27:

Looks reasonable.

I haven't re-tested packaging and multi-monitors with XMir, but it worked brilliantly when I did so last week.

review: Approve

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2013-09-27:

Re-tested with XMir. Verified bug 1216472 is fixed!

review: Approve

Revision history for this message

Alan Griffiths (alan-griffiths) wrote on 2013-09-27: