Merge lp://staging/~adiroiban/pydoctor/1282458-apilinks-anchor into lp://staging/~mwhudson/pydoctor/dev

Hi. Thanks for proposing this branch!

It would probably have been better to do the different things in different branches maybe?

I don't use py.test any more to run the tests, but generally use nose instead. I'm not super happy about either tbh, and would like to convert them all to something more standardly-pyUnitish but well.

I don't know how apilinks_sphinxext.py is used at all -- if it is still useful when part of the pydoctor package, then it makes sense for it to be there rather than at top level.

I can split this review... but considering that this is the only branch in the review queue I don't know what splitting it will make things easier.

I use nose and I am happy with it. Much better than standard pyunit.

I tried to use, but test were failing so I did not dig deeper and just went to install py.test, since I saw that tests required 'py' package which was talking about pytest.

apilinks_sphinxext.py is used in Twisted, but is not used as part of pydoctor package, but instead there is a copy of this file.

Thanks!

Adi Roiban <email address hidden> writes:

> I can split this review... but considering that this is the only
> branch in the review queue I don't know what splitting it will make
> things easier.

Well I find it helps to talk about one thing at once but you make a fair
point.

> I use nose and I am happy with it. Much better than standard pyunit.

OK, so...

> I tried to use, but test were failing so I did not dig deeper and just
> went to install py.test, since I saw that tests required 'py' package
> which was talking about pytest.

Can you try again? I think I just deleted the last remnants of the py
imports.

> apilinks_sphinxext.py is used in Twisted, but is not used as part of
> pydoctor package, but instead there is a copy of this file.

Right, I think we should be moving towards only having one copy of the
file but I don't know what's involved in that.

Cheers,
mwh

I tried nosetests on trunk and there are still errors: https://gist.github.com/adiroiban/9125421

I like nosetests and so I would like to use it instead of py.test. That all :)

I will ask over twisted mailing list and try to get some feedback about how apilinks_sphinxext.py should be distributed.

My initial but report/patch was on Twisted Trac and there I was asked to send patch here... feels like bad communication.

Thanks!

Adi Roiban <email address hidden> writes:

> I tried nosetests on trunk and there are still errors: https://gist.github.com/adiroiban/9125421

Argh, I think I've fixed the final final import of py...

> I like nosetests and so I would like to use it instead of py.test. That all :)

Good!

> I will ask over twisted mailing list and try to get some feedback about how apilinks_sphinxext.py should be distributed.

That'd be great.

> My initial but report/patch was on Twisted Trac and there I was asked
> to send patch here... feels like bad communication.

Well, if you'd just sent me the change to apilinks_sphinxext, it'd have
been merged by now. I'm sorry there was no CONTRIBUTING.txt and thanks
for trying to write one, but it's not surprising that it was hard for
you to guess what should be in there!

Cheers,
mwh

All good now. I have updated requirements. I will wait for feedback from Twisted developers. I am not in a hurry to have this merged.

While this code is in a single branch, I think that you can always pick some files from here, changed them as you like and commit them in trunk.

As long as you can just push a commit in trunk without a bug report and a review request, I feel that is unfair to ask contributors to spend extra effort for creating bugs and review requests for such simple things.
No hard feelings, just sincere feedback!

Thanks!