Merge lp://staging/~adiroiban/pocket-lint/travis-ci into lp://staging/pocket-lint

I merged your branch, made a single line decoding fix for py3.3, the committed. The tests pass, though since I do not have closure installed. 2 were skipped. I assume the tests work for you and I will verify this when I get more network.

Oops, wrong MP, sorry. I need to move this make and study it. I will claim it needs information since Lp wont let me undo this.

No problem.

If we have travis-ci running, I can also install google-closure in the environment and make sure google-closure tests are executed.

This branch conflicts with your pep8 branch that is merged.

I would prefer that
    python_version = sys.version_info
becomes
    IS_PY3 = IS_PY3
which can be imported from formatcheck...

...but is it needed. The py2 tests fail for me with the change. py2 and py3 both pass with "enclosed in double quotes"

First differing element 0:
(2, u'Expecting property name: line 2 column 1 (char 2)')
(2, 'Expecting property name enclosed in double quotes: line 2 column 1 (char 2)')

+ [(2,
- [(2, u'Expecting property name: line 2 column 1 (char 2)')]
? ^^^^^^

+ 'Expecting property name enclosed in double quotes: line 2 column 1 (char 2)')]
? ^^ ++++++++++++++++++++++++++

I will use IS_PY3 ... sorry for that. I was not aware of this convention.

I have renamed requires to install_requires so that they will be installed by pip http://stackoverflow.com/questions/10335371/pip-does-not-install-dependency-declared-in-setup-requires-parameter

It looks like the PY3 check is required as this build fails : https://travis-ci.org/chevah/pocket-lint/builds/18262140

With the exception for py3 the test pass : https://travis-ci.org/chevah/pocket-lint/builds/18262337

The code works on Travis-CI https://travis-ci.org/chevah/pocket-lint

I have no idea why the MERGE markers are listed in this diff. I checked the branch and there are no markers: http://bazaar.launchpad.net/~adiroiban/pocket-lint/travis-ci/view/head:/setup.py

Please review latest changes. Thanks!

Hi Adi.

This branch has a lot of merge conflicts. I think many are caused by other improvements that I just merged. I cannot make sense of them. I update setup.py and test.py since I understood your changes. Maybe you need to resubmit this branch to convince Lp to list all the conflicts.

Hi and thanks for the reviews. Don't worry for the delay.

Hi, I have merged trunk.

The build passed on Travis-CI https://travis-ci.org/chevah/pocket-lint/builds/20438350

For now, travis-ci integration is not very useful for other people as I have to manually sync bzr to git.
Does LP has any hook to trigger an event when someone pushes to a branch attached to a project?

For me it is a great help since I can run test in an independent-environment... and since I use git-bzr-ng it is easy to trigger git updates and travis-ci builds.

I have not configured email notifications for Travis-CI yet so it's only my who receives email notifications.

--------

I don't know why LP shows the diff markers.

I have checked my local file at rev 512 and it looks ok.

This line should be removed

requires=['pyflakes (>=7.3)', 'pep8 (>=1.4.6)'],

and add the new format.

install_requires=['pyflakes>=0.7.3', 'pep8>=1.4.6'],

Thanks!

[1] https://github.com/termie/git-bzr-ng

I don't think this will work because it is used by steup tools
    install_requires=['pyflakes>=0.7.3', 'pep8>=1.4.6'],
setup.py uses distutils which wants this format
    requires=['pyflakes (>=7.3)', 'pep8 (>=1.4.6)'],

True... I see the warning... python packaging tools are a bit of a mess :(

How 'requires' is used in the context of distutils?

I have changed to install_requires since without that, pip install will not install the dependencies.

In the penultimate revision I added both version... with duplicate info but I don't like it :(

Is there a reason to keep using distutils and not setuptools, or at least not trying to use setuptools?

In the last revision I went for setuptools as primary tools and failing to disutils if setuptools are not found.

I find setuptools install command or pip install command much useful than distutils install commnand.

-----

While checking the sdist command, I see that it runs the tests, but will not prevent building the distribution if tests fails... maybe it needs something like this:

    def run(self):
        test_loader = unittest.defaultTestLoader
        suite = unittest.TestSuite()
        for test_module in test_loader.discover('pocketlint'):
            suite.addTest(test_module)
        result = unittest.TextTestRunner(verbosity=1).run(suite)
        if len(result.failures) or len(result.errors):
            raise AssertionError('Test have failed.')

Thanks!

hm... there is no penultimate commit since git to bzr conversion has squashed my git commits.

Here is the penultimate diff https://github.com/chevah/pocket-lint/commit/9928a0c606e9e965d06ccc3c6db22b1c2512e8b6

Hi,

Any change you can look at the latest code?

I would be more than happy to see Travis-CI integration working and have a place to check that new changes don't break previous things.

Thanks!