Merge lp://staging/~adiroiban/pocket-lint/pep-options into lp://staging/pocket-lint
Proposed by
Adi Roiban
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 447 | ||||
| Proposed branch: | lp://staging/~adiroiban/pocket-lint/pep-options | ||||
| Merge into: | lp://staging/pocket-lint | ||||
| Diff against target: |
302 lines (+113/-52) 4 files modified
NEWS (+7/-0) pocketlint/formatcheck.py (+57/-36) pocketlint/tests/test_javascript.py (+37/-16) pocketlint/tests/test_python.py (+12/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~adiroiban/pocket-lint/pep-options | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Curtis Hovey | code | Approve | |
|
Review via email:
|
|||
Description of the change
Description
-----------
PEP8 has now at least one controversion option... but users might want to ignore some pep8 messages.
Changes
-------
I have created a dedicated (more complex) object to hold all pocket-lint options.
It can extend the command line options.
The current code was done to minimize changes and provide backward compatibility.
I have done a refactored the UniversalChecker to use the init from BaseClass.
I have also updated the NEWS file. I find it easier to check latest changes in a single file, rather than look into VC history.
Test
----
I have run the tests on py2.7 ... looking forward for travis-ci integration to land on master and then we can see a neutral results on both 2.7 and 3.3
Please review the changes.
Thanks!
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thank you.
I reconciled some changes/tests with the previous branches I just merged. I am going to extend PocketLintOptions
in a moment to support PEP8's options.
are indented.