Merge lp://staging/~adiroiban/pocket-lint/986239 into lp://staging/pocket-lint
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Curtis Hovey | ||||
| Approved revision: | 469 | ||||
| Merged at revision: | 468 | ||||
| Proposed branch: | lp://staging/~adiroiban/pocket-lint/986239 | ||||
| Merge into: | lp://staging/pocket-lint | ||||
| Diff against target: |
868 lines (+790/-2) 4 files modified
pocketlint/formatcheck.py (+245/-0) pocketlint/tests/__init__.py (+1/-0) pocketlint/tests/test_restructuredtext.py (+524/-0) test.py (+20/-2) |
||||
| To merge this branch: | bzr merge lp://staging/~adiroiban/pocket-lint/986239 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Curtis Hovey | code | Approve | |
|
Review via email:
|
|||
Description of the change
Hi,
This is my initial rst checker.
It contains a few changes outside of the rst part.
1. For the test runner I added the option to select the test based on regex. In this was I was able to run only a subset of test modules.
2. For the general CheckerTestCase, i set self.reporter.
Please let me know if you want me to revert these changes.
----
Now for the RST part.
For the Language class, I wanted to sort the language type identifier objects, mimetypes.add_type and mime_type_language in alphabetic order... but I didn't want to add to much noise to the diff.
I know that it is hard to force a certain coding convention and the current rules are made base on the style used in the Python documentation.
It does not checks for rst compilation errors, but rather for coding conventions.
For not it only checks for sections styles and an empty line at the end of file.
Please let me know if you thinks this is on a right direction and what should be changed.
Thanks!
Adi
Thank you very much.
I have merged this and pushed it to Launchpad. I think there are a few methods that return True or False that could be made smaller and more precise. I do not think they need changing just yet. I think it is best that this feature be merged and used so that we know exactly where we want to improve it.