pocket-lint

Merge lp://staging/~adiroiban/pocket-lint/1237489-pep8-upstream into lp://staging/pocket-lint

  1. 1237489-pep8-upstream
  2. Merge into trunk
Proposed by Adi Roiban
Status: Merged
Approved by: Curtis Hovey
Approved revision: 504
Merged at revision: 508
Proposed branch: lp://staging/~adiroiban/pocket-lint/1237489-pep8-upstream
Merge into: lp://staging/pocket-lint
Diff against target: 1960 lines (+1/-1944)
2 files modified
pocketlint/contrib/pep8.py (+0/-1943)
pocketlint/formatcheck.py (+1/-1)
To merge this branch: bzr merge lp://staging/~adiroiban/pocket-lint/1237489-pep8-upstream
Reviewer Review Type Date Requested Status
Curtis Hovey code Approve
Review via email: mp+190183@code.staging.launchpad.net

Description of the change

This is the branch which removed the contrib/pep8 and used the default pep8.

I have tried this branch with pep8-1.4.6 in an virtualenv and there were no errors.

Please let me know why if this change is valid.

Thanks!

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you. I accept this. I believe that pocketlint needs python-pep8 and python3-pep8 installed to work properly in saucy. There will be a delay getting this into the unstable ppa because I have a busy schedule and I am in the the middlw of rewriting the packaging rules

review: Approve (code)
Revision history for this message
Adi Roiban (adiroiban) wrote :

Thanks.

I don't use Ubuntu packages for Python. I prefer virtualenv and pip since this solution is flexible and is not locked to an OS.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: