Launchpad itself

Merge lp://staging/~adeuring/launchpad/bug-758902 into lp://staging/launchpad

  1. bug-758902
  2. Merge into devel
Proposed by Abel Deuring
Status: Merged
Approved by: Aaron Bentley
Approved revision: no longer in the source branch.
Merged at revision: 12825
Proposed branch: lp://staging/~adeuring/launchpad/bug-758902
Merge into: lp://staging/launchpad
Diff against target: 67 lines (+27/-10)
2 files modified
lib/lp/registry/browser/sourcepackage.py (+11/-7)
lib/lp/registry/browser/tests/sourcepackage-views.txt (+16/-3)
To merge this branch: bzr merge lp://staging/~adeuring/launchpad/bug-758902
Reviewer Review Type Date Requested Status
Aaron Bentley (community) Approve
Review via email: mp+57502@code.staging.launchpad.net

Commit message

[r=abentley][bug=758902] avoid an OOPS when somebody tries to delete a packaging link more than once.

Description of the change

This branch fixes bug 758902: "OOPS unlinking package association in translations details page"

The problem is trivial: PackagingUtil.deletePackaging() raises an assertion error if the the given productseries and sourcepackage are not/no longer linked by a packaging record.

The fix is equally trivial: SourcePackageRemoveUpstreamView.unlink() should call deletePackaging() if the packaging record still exists.

test: ./bin/test registry -vvt sourcepackage-views.txt

no lint

To post a comment you must log in.
Revision history for this message
Aaron Bentley (abentley) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.