Merge lp://staging/~adeuring/launchpad/bug-591323-slave-db-for-bug-searches into lp://staging/launchpad

Proposed by Abel Deuring
Status: Merged
Approved by: Graham Binns
Approved revision: no longer in the source branch.
Merged at revision: 11022
Proposed branch: lp://staging/~adeuring/launchpad/bug-591323-slave-db-for-bug-searches
Merge into: lp://staging/launchpad
Diff against target: 54 lines (+6/-2)
3 files modified
lib/lp/bugs/browser/tests/person-bug-views.txt (+2/-0)
lib/lp/bugs/doc/milestones-from-bugtask-search.txt (+1/-0)
lib/lp/bugs/model/bugtask.py (+3/-2)
To merge this branch: bzr merge lp://staging/~adeuring/launchpad/bug-591323-slave-db-for-bug-searches
Reviewer Review Type Date Requested Status
Graham Binns (community) code Approve
Review via email: mp+27810@code.staging.launchpad.net

Description of the change

This branch lets the main bug search method use a slave database.

While this is just a two-line change, i ran "make check" to find possible test failures: New objects created in the master DB by testfactory.makeSomething() are not immediately available in the slave DB. I added a transaction.commit() in the (suprisingly few) tests where a bug search test depends on factory-created obejcts.

tests: anything bug search related, for example

  ./bin/test -t bugtask-search.txt

and the two changed tests:

./bin/test -t person-bug-views.txt
./bin/test -t milestones-from-bugtask-search.txt

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/bugs/browser/tests/person-bug-views.txt
  lib/lp/bugs/doc/milestones-from-bugtask-search.txt
  lib/lp/bugs/model/bugtask.py

To post a comment you must log in.
Revision history for this message
Graham Binns (gmb) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.