CI Director

Merge lp://staging/~adeuring/ci-director/archive-build-summary into lp://staging/ci-director

  1. archive-build-summary
  2. Merge into trunk
Proposed by Abel Deuring
Status: Merged
Merged at revision: 117
Proposed branch: lp://staging/~adeuring/ci-director/archive-build-summary
Merge into: lp://staging/ci-director
Diff against target: 299 lines (+106/-38)
4 files modified
cidirector/cidirector.py (+21/-2)
cidirector/storage.py (+6/-5)
cidirector/tests/test_cidirector.py (+71/-31)
cidirector/utility.py (+8/-0)
To merge this branch: bzr merge lp://staging/~adeuring/ci-director/archive-build-summary
Reviewer Review Type Date Requested Status
Aaron Bentley (community) Approve
Review via email: mp+227752@code.staging.launchpad.net

Description of the change

This branch changes ResultJudge.send_final_mail() so that it will also store the details of the build in the S3 "archive" bucket.

To post a comment you must log in.
Revision history for this message
Aaron Bentley (abentley) wrote :

This looks good. Please rename send_final_mail to something else, now that it is doing more. Maybe finish() or finalize() or wrap_up()?

review: Approve
lp://staging/~adeuring/ci-director/archive-build-summary updated
118. By Abel Deuring

ResultJudge.send_finla_mail(9 renamed to finalize()

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches