Landscape Client

Merge lp://staging/~adam-collard/landscape-client/mocker-replace-configuration into lp://staging/~landscape/landscape-client/trunk

  1. mocker-replace-configuration
  2. Merge into trunk
Proposed by Adam Collard
Status: Merged
Approved by: Adam Collard
Approved revision: 848
Merged at revision: 876
Proposed branch: lp://staging/~adam-collard/landscape-client/mocker-replace-configuration
Merge into: lp://staging/~landscape/landscape-client/trunk
Diff against target: 916 lines (+289/-365)
1 file modified
landscape/tests/test_configuration.py (+289/-365)
To merge this branch: bzr merge lp://staging/~adam-collard/landscape-client/mocker-replace-configuration
Reviewer Review Type Date Requested Status
Chad Smith Approve
🤖 Landscape Builder test results Approve
Chris Glass (community) Approve
Review via email: mp+297550@code.staging.launchpad.net

Commit message

First part of the conversion from mocker to mock of test_configuration.py

Replace mocker in PrintTextTest and LandscapeSetupScriptTest

Description of the change

First part of the conversion from mocker to mock of test_configuration.py

This branch does the replacement of mocker in PrintTextTest and LandscapeSetupScriptTest

Further conversion of the module will occur in follow up branches.

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make check
Result: Success
Revno: 845
Branch: lp:~adam-collard/landscape-client/mocker-replace-configuration
Jenkins: https://ci.lscape.net/job/latch-test/5055/

review: Approve (test results)
Revision history for this message
Chris Glass (tribaal) wrote :

+1

review: Approve
lp://staging/~adam-collard/landscape-client/mocker-replace-configuration updated
846. By Adam Collard

Replace excessive @mock.patch with inline monkey patching

Revision history for this message
Chad Smith (chad.smith) :
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make check
Result: Success
Revno: 846
Branch: lp:~adam-collard/landscape-client/mocker-replace-configuration
Jenkins: https://ci.lscape.net/job/latch-test/5068/

review: Approve (test results)
Revision history for this message
Chad Smith (chad.smith) :
lp://staging/~adam-collard/landscape-client/mocker-replace-configuration updated
847. By Adam Collard

Use [call] for tuple unpacking rather than call, (bbsw's review)

Revision history for this message
Adam Collard (adam-collard) :
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 847
Branch: lp:~adam-collard/landscape-client/mocker-replace-configuration
Jenkins: https://ci.lscape.net/job/latch-test/5070/

review: Approve (test results)
Revision history for this message
Chad Smith (chad.smith) wrote :

+1 one last inline comment. Thanks!!!!!

review: Approve
lp://staging/~adam-collard/landscape-client/mocker-replace-configuration updated
848. By Adam Collard

Assert that show_help is only called once (bbsw's review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: