Merge lp://staging/~adam-collard/landscape-client/mocker-replace-configuration-iii into lp://staging/~landscape/landscape-client/trunk

Proposed by Adam Collard
Status: Merged
Approved by: Adam Collard
Approved revision: 853
Merged at revision: 893
Proposed branch: lp://staging/~adam-collard/landscape-client/mocker-replace-configuration-iii
Merge into: lp://staging/~landscape/landscape-client/trunk
Prerequisite: lp://staging/~adam-collard/landscape-client/mocker-replace-configuration-part-deux
Diff against target: 65 lines (+9/-20)
1 file modified
landscape/tests/test_configuration.py (+9/-20)
To merge this branch: bzr merge lp://staging/~adam-collard/landscape-client/mocker-replace-configuration-iii
Reviewer Review Type Date Requested Status
Simon Poirier (community) Approve
Chris Glass (community) Approve
🤖 Landscape Builder test results Approve
Review via email: mp+297638@code.staging.launchpad.net

Commit message

The final part of porting test_configuration.py 🙌

Description of the change

The final part of porting test_configuration.py 🙌

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Fail
Revno: 852
Branch: lp:~adam-collard/landscape-client/mocker-replace-configuration-iii
Jenkins: https://ci.lscape.net/job/latch-test/5091/

review: Needs Fixing (test results)
853. By Adam Collard

Merge from parent branch

Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 853
Branch: lp:~adam-collard/landscape-client/mocker-replace-configuration-iii
Jenkins: https://ci.lscape.net/job/latch-test/5095/

review: Approve (test results)
Revision history for this message
Chris Glass (tribaal) wrote :

+1

review: Approve
Revision history for this message
Simon Poirier (simpoir) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: